Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-4727] Compare runs - Parameters expandable section #2690

Conversation

jpuzz0
Copy link
Contributor

@jpuzz0 jpuzz0 commented Apr 8, 2024

Closes: RHOAIENG-4727

Description

Compare runs - Parameters expandable section renders runtime config data associated with all selected runs from the Run list, where if a run does not share a parameter with another, empty cells are shown. The feature has a switch that allows for showing and hiding of parameter rows based on whether rows possess all of the same value. When row data extends beyond a certain point, horizontal scroll will kick in and the first column representing parameter names will stick while scrolling left and right.

NOTE: The design diverged slightly from what the mocks show at the moment. The implementation here is what was recently agreed upon with @yannnz.

image

Only showing parameters with values that differ between runs
image

Empty state
image

How Has This Been Tested?

Added cypress tests demonstrating interactions between the Run list and Parameters tables, along with hiding of parameters with values that are all equal.

How to test

Navigate to the Compare runs page /experiments/jps-fun-world/85c9d729-bf63-441f-af87-d6898e5db5f0/compareRuns?runs=[your list of runs here], verify the table design and interactions with the Run list above it.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot requested review from pnaik1 and uidoyen April 8, 2024 20:04
Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good besides the question on background color. will test it locally tomorrow

@jpuzz0 jpuzz0 force-pushed the RHOAIENG-4727-compare-runs-params-section branch 4 times, most recently from 9fe70ba to 8938d5e Compare April 11, 2024 13:32
@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Apr 12, 2024
@jpuzz0 jpuzz0 force-pushed the RHOAIENG-4727-compare-runs-params-section branch from 8938d5e to 050cf3e Compare April 12, 2024 13:26
@openshift-merge-robot openshift-merge-robot removed the needs-rebase PR needs to be rebased label Apr 12, 2024
@jpuzz0 jpuzz0 force-pushed the RHOAIENG-4727-compare-runs-params-section branch from 050cf3e to 343a6b0 Compare April 16, 2024 18:15
Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Apr 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 74e9c79 into opendatahub-io:main Apr 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants