-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove last remaining traces of modelMetricsNamespace flag #2438
Remove last remaining traces of modelMetricsNamespace flag #2438
Conversation
Oh, you broke tests... no approval for you 🙂 |
@alexcreasy should we merge this? it's been open for a couple of months |
/retest |
727e1e3
to
dd0dca3
Compare
Okay, GitHub allowed a rebase -- the test info was lost and seemed to not want me to retest it -- so I figured this way we can try to merge this if the tests pass. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2438 +/- ##
==========================================
- Coverage 78.14% 78.11% -0.04%
==========================================
Files 1076 1076
Lines 22629 22615 -14
Branches 5722 5718 -4
==========================================
- Hits 17684 17665 -19
- Misses 4945 4950 +5
... and 12 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
dd0dca3
to
0cd4f81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to not be on Alex's radar -- going to merge as-is, it's minor cleanup.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Removes a few orphaned references to the removed
modelMetricsNamespace
flag.How Has This Been Tested?
Test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main