Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-1124] Initial pipeline runs global page test setup #2398

Conversation

jpuzz0
Copy link
Contributor

@jpuzz0 jpuzz0 commented Jan 25, 2024

Description

Initial page objects for the global runs page and supporting tables. Only a placeholder test was written for now. Opening this to avoid too many conflicts with others writing tests for other functionality on the page.

@jpuzz0 jpuzz0 requested review from Gkrumbach07 and removed request for manaswinidas and ppadti January 25, 2024 16:49
@jpuzz0 jpuzz0 force-pushed the RHOAIENG-1124-initial-pipeline-runs-cypress-setup branch from 7020a1b to d9976c7 Compare January 25, 2024 16:51
@jpuzz0 jpuzz0 force-pushed the RHOAIENG-1124-initial-pipeline-runs-cypress-setup branch from 751df03 to 991141e Compare January 25, 2024 20:03
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jpuzz0 jpuzz0 force-pushed the RHOAIENG-1124-initial-pipeline-runs-cypress-setup branch from 991141e to eaf3aee Compare January 25, 2024 20:11
@openshift-ci openshift-ci bot removed the lgtm label Jan 25, 2024
Copy link
Contributor

openshift-ci bot commented Jan 25, 2024

New changes are detected. LGTM label has been removed.

Copy link
Contributor

openshift-ci bot commented Jan 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: DaoDaoNoCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b156391 into opendatahub-io:f/pipelines-enhancement Jan 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants