Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more tests to enabling trusty #2353

Merged

Conversation

Gkrumbach07
Copy link
Member

@Gkrumbach07 Gkrumbach07 commented Jan 17, 2024

closes: https://issues.redhat.com/browse/RHOAIENG-365

Description

added tests to the trustyai widget

How Has This Been Tested?

tests pass

Test Impact

tests now look more into the errors and actual api responses.

  • timeout error
  • service error
  • success alert removed bc it uses polling and tests don't have polling enabled
  • proper submit post

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot requested review from ppadti and uidoyen January 17, 2024 23:25
@alexcreasy
Copy link
Contributor

@Gkrumbach07 I tried this locally and got the same failure for the "Enable Trusty AI" test as the CI did.

Screenshot 2024-01-18 at 11 43 26

@Gkrumbach07
Copy link
Member Author

@alexcreasy this might be a timeout issue. Becuase for success alert to occur it first needs to be in progress (1 request) and then poll for another request and be ready (another request).... this polling timing may be slightly off across envs so i increased timeout

@Gkrumbach07 Gkrumbach07 force-pushed the story/RHOAIENG-365 branch 3 times, most recently from fe84c8e to ca0401b Compare January 18, 2024 18:28
removed test with polling
@christianvogt
Copy link
Contributor

/lgtm
/approve
/retest

Copy link
Contributor

openshift-ci bot commented Jan 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 8733c1d into opendatahub-io:main Jan 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants