-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to duplicate a serving runtime #2339
Unable to duplicate a serving runtime #2339
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look great, we need testing coverage and we should tag @vconzola to review the changes.
frontend/src/pages/modelServing/customServingRuntimes/CustomServingRuntimeAddTemplate.tsx
Outdated
Show resolved
Hide resolved
This is not only a label change, que should add coverage to tests that adding a new SR will display "Add" and if we try to duplicate it will get "Duplicate..." |
The page title change looks OK, but you should also change the description text below the title. The text should say, "Add a new, editable runtime by duplicating an existing runtime." |
2ea5f10
to
423cb31
Compare
423cb31
to
e9f385c
Compare
@lucferbux, Cypess test added and also refactored the test file according to cypress test structure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Great job here!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lucferbux The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes: RHOAIENG-552
Description
Changed the label for Duplicating serving runtime
How Has This Been Tested?
Test Impact
Added integration test to check page headings for Add, Duplicate and Edit.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main
@vconzola