Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to duplicate a serving runtime #2339

Merged

Conversation

dpanshug
Copy link
Contributor

@dpanshug dpanshug commented Jan 16, 2024

Closes: RHOAIENG-552

Description

Changed the label for Duplicating serving runtime

image

How Has This Been Tested?

  1. Create an OOTB serving runtime
  2. Try duplicating it

Test Impact

Added integration test to check page headings for Add, Duplicate and Edit.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@vconzola

Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look great, we need testing coverage and we should tag @vconzola to review the changes.

@lucferbux
Copy link
Contributor

This is not only a label change, que should add coverage to tests that adding a new SR will display "Add" and if we try to duplicate it will get "Duplicate..."

@vconzola
Copy link

vconzola commented Jan 16, 2024

The page title change looks OK, but you should also change the description text below the title. The text should say, "Add a new, editable runtime by duplicating an existing runtime."

@dpanshug
Copy link
Contributor Author

@lucferbux, Cypess test added and also refactored the test file according to cypress test structure

Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Great job here!

@openshift-ci openshift-ci bot added the lgtm label Jan 17, 2024
Copy link
Contributor

openshift-ci bot commented Jan 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 6219e72 into opendatahub-io:main Jan 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants