Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-1451: Detect deleted pipeline versions on pipeline runs table, disable, show tooltip #2335

Conversation

jpuzz0
Copy link
Contributor

@jpuzz0 jpuzz0 commented Jan 12, 2024

Closes: RHOAIENG-1451

Description

For the pipeline runs table, fetch the pipeline version associated with the runs, and if no pipeline version is returned, that version no longer exists, and we show the name as disabled with a tooltip indicating that the version "no longer exists."

How Has This Been Tested?

Only regression tested by simply navigating to the pipeline runs table with runs that have pipeline versions that have been deleted, and seeing that on-hover of any disabled text for pipeline versions that a tooltip is shown stating the version no longer exists.

image

Test Impact

Tests will be written as a follow-up.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@jpuzz0 jpuzz0 requested review from yannnz and DaoDaoNoCode and removed request for uidoyen and dpanshug January 12, 2024 15:15
@jpuzz0 jpuzz0 force-pushed the RHOAIENG-1451-disable-deleted-versions branch 2 times, most recently from 9295564 to 3e2ca7f Compare January 12, 2024 15:56
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pipeline field on the pipeline run details page should also be disabled and added the tooltip if the version no longer not exists.

Screenshot 2024-01-12 at 11 43 47 AM

@DaoDaoNoCode
Copy link
Member

Also, I am wondering if we should disable the duplicate button in the table row dropdown menu and the pipeline run details page header actions for those runs with unavailable versions. Any ideas? @jpuzz0 @yannnz I think it makes no sense for them to duplicate a run using an outdated version because we could not find it at all. (If we don't disable the duplicate button, the result would be only pre-filling the name to Duplicate of run xxx) with not pipeline and version selection, makes it very slightly different from creating a new run.

Copy link
Contributor

@manaswinidas manaswinidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pipeline field on the pipeline run details page should also be disabled and added the tooltip if the version no longer not exists.

@DaoDaoNoCode I agree, also should we be adding a "Pipeline version" field to the Pipeline Run Details tab? Maybe both Pipeline and Pipeline Version or maybe just Pipeline Version as sometimes we may have a Pipeline but not a version(not a part of this issue, can be addressed later).

Tested the tooltip for deleted pipeline version, works fine.

@jpuzz0 jpuzz0 force-pushed the RHOAIENG-1451-disable-deleted-versions branch 3 times, most recently from 0837924 to e80d286 Compare January 15, 2024 16:00
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small nit, otherwise it looks good to me, I will address the duplication button disable issue later in my PR

frontend/src/concepts/pipelines/content/tables/utils.ts Outdated Show resolved Hide resolved
@jpuzz0 jpuzz0 force-pushed the RHOAIENG-1451-disable-deleted-versions branch from e80d286 to d4a3f67 Compare January 15, 2024 16:59
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Jan 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: DaoDaoNoCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit cc59a36 into opendatahub-io:f/pipelines-enhancement Jan 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants