-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHOAIENG-1451: Detect deleted pipeline versions on pipeline runs table, disable, show tooltip #2335
Conversation
9295564
to
3e2ca7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I am wondering if we should disable the duplicate button in the table row dropdown menu and the pipeline run details page header actions for those runs with unavailable versions. Any ideas? @jpuzz0 @yannnz I think it makes no sense for them to duplicate a run using an outdated version because we could not find it at all. (If we don't disable the duplicate button, the result would be only pre-filling the name to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pipeline field on the pipeline run details page should also be disabled and added the tooltip if the version no longer not exists.
@DaoDaoNoCode I agree, also should we be adding a "Pipeline version" field to the Pipeline Run Details tab? Maybe both Pipeline and Pipeline Version or maybe just Pipeline Version as sometimes we may have a Pipeline but not a version(not a part of this issue, can be addressed later).
Tested the tooltip for deleted pipeline version, works fine.
0837924
to
e80d286
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small nit, otherwise it looks good to me, I will address the duplication button disable issue later in my PR
…e and disable the link
e80d286
to
d4a3f67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: DaoDaoNoCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cc59a36
into
opendatahub-io:f/pipelines-enhancement
Closes: RHOAIENG-1451
Description
For the pipeline runs table, fetch the pipeline version associated with the runs, and if no pipeline version is returned, that version no longer exists, and we show the name as disabled with a tooltip indicating that the version "no longer exists."
How Has This Been Tested?
Only regression tested by simply navigating to the pipeline runs table with runs that have pipeline versions that have been deleted, and seeing that on-hover of any disabled text for pipeline versions that a tooltip is shown stating the version no longer exists.
Test Impact
Tests will be written as a follow-up.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main