support workbench-image-recommended annotation being set to false

[Gkrumbach07]

closes: https://issues.redhat.com/browse/RHOAIENG-937

Description

check that opendatahub.io/workbench-image-recommended: 'false' does not show the recommended label.

Note: the jupyter tile already does this in the backend, so no need to do anything there.

How Has This Been Tested?

1. edit any imagestream tag's annotation for opendatahub.io/workbench-image-recommended: 'false' and verify that in the UI the recommended label is not shown. You can see this when going to the workbench spawner and selecting a version for the image you changed.

Test Impact

added util test to test how different annotation values are handled

Request review criteria:

Self checklist (all need to be checked):

• The developer has manually tested the changes and verified that the changes work
• Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

• Included any necessary screenshots or gifs if it was a UI change.
• Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

• The developer has tested their solution on a cluster by using the image produced by the PR to main

[andrewballantyne]

Do both Jupyter tile and DS Projects please... needs a backend change for that

[Gkrumbach07]

@andrewballantyne

Do both Jupyter tile and DS Projects please... needs a backend change for that

Jupyter tile already supports it

for reference. this is how it is computed

const tagInfo: ImageTagInfo = {
      ...
      recommended: JSON.parse(tagAnnotations[IMAGE_ANNOTATIONS.RECOMMENDED] || 'false'),
    };

[andrewballantyne]

Looks good, I swore when I looked at this earlier it was both backend and frontend changes, but tested it and it looks great with just frontend changes. Nicely done!

Before:

After:
(no change to Jupyter tile)

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [andrewballantyne]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment