Prevent download of empty files in Pipeline Logs

[manaswinidas]

JIRA: RHOAIENG-259

Description

This PR :

• Prevents downloading empty log files
• Some changes to align with mocks
• Handles small screen "Download" button for pods with a single step
• Add functionality to view raw logs (part of Future improvements for Pipeline run log viewer #1814)
• Code refactor
  

GIF for raw logs:

Screen.Recording.2023-11-30.at.7.35.07.PM.mov

Screenshots for view raw logs and disabled and enabled states of both Raw logs and Download button:

Enabled state:

Disabled:

Small screen:

How Has This Been Tested?

1. Run any pipeline
2. Go to the Logs tab
3. Go to any node that has completed execution but has no logs
4. Check that you see "No logs available" and the "Download" button is disabled

Test Impact

Added tests to check whether the drawer opens on clicking the node of a pipeline run

Request review criteria:

Self checklist (all need to be checked):

• The developer has manually tested the changes and verified that the changes work
• Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

• Included any necessary screenshots or gifs if it was a UI change.
• Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

• The developer has tested their solution on a cluster by using the image produced by the PR to main

[DaoDaoNoCode]

The download all step logs link button in the alert should also be disabled when the file is empty. Otherwise, I can still download empty files.

[manaswinidas]

@DaoDaoNoCode Oh yes, I missed this. Thanks for pointing this out. Added now.

[dpanshug]

Disabling the download all step logs should not depend on the selected step.

When selected step with logs, the button is enabled.

When selected step without logs, the button gets disabled.

the link button should be enabled for all steps, if one step has a log

[DaoDaoNoCode]

Code lgtm, needs to run through it tomorrow to test. My internet is still down now for the whole afternoon so I got very limited internet access.

[DaoDaoNoCode]

Tested, works fine.
/lgtm

[DaoDaoNoCode]

I feel the logic is not correct here... if you simply do !(podContainers.length === 1 && !logs) you will get podContainers.length !== 1 || !!logs

[DaoDaoNoCode]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: DaoDaoNoCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

The request changes have been addressed