-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance metric chart needs area charts to be in a stack #2114
Performance metric chart needs area charts to be in a stack #2114
Conversation
463c23c
to
d49f3a4
Compare
@vconzola is this OK for the "stack" issue (I'll take care of the x100 part in another ticket). I've changed the colour scheme from green / red to one of the standard ones as I don't know much about a11y but I know red / green on top of each other is a no no. The colour scheme can be changed easily during incubation if required. |
Yes, it looks good to me now. Wrt accessibility, if we want to go back to the red/green paradigm there's a way to do it and keep it accessible. I talked to one of the PF devs and he suggested just applying a pattern to one of the graphs (probably successes). This would make the two graphs distinguishable with the user being able to see a color difference. |
Thanks @vconzola, if we decide that's the route we want to go down it's a fairly straightforward change from my end |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d49f3a4
to
4e321d5
Compare
New changes are detected. LGTM label has been removed. |
358b29e
into
opendatahub-io:f/mserving-metrics
Closes: #2090
Description
Makes the following changes:
How Has This Been Tested?
Test Impact
Area is not yet tested so no impact.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main