Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance metric chart needs area charts to be in a stack #2114

Merged

Conversation

alexcreasy
Copy link
Contributor

@alexcreasy alexcreasy commented Nov 9, 2023

Closes: #2090

Description

Makes the following changes:

  • Model metrics and server metrics HTTP requests charts are now stacks
  • Fixes a bug with stack charts where the domain is truncated
  • Changes the colour scheme away from red / green to avoid a11y issues
issue-2090

How Has This Been Tested?

  • Check the HTTP charts for server and model metrics ensuring they are now a stack (i.e. successful and failed requests add up to a total value, so if there are 5 failed requests and 5 successful requests at the same time, the total on the graph should be 10 at that point).

Test Impact

Area is not yet tested so no impact.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@alexcreasy
Copy link
Contributor Author

alexcreasy commented Nov 9, 2023

@vconzola is this OK for the "stack" issue (I'll take care of the x100 part in another ticket). I've changed the colour scheme from green / red to one of the standard ones as I don't know much about a11y but I know red / green on top of each other is a no no. The colour scheme can be changed easily during incubation if required.

@vconzola
Copy link

vconzola commented Nov 9, 2023

Yes, it looks good to me now. Wrt accessibility, if we want to go back to the red/green paradigm there's a way to do it and keep it accessible. I talked to one of the PF devs and he suggested just applying a pattern to one of the graphs (probably successes). This would make the two graphs distinguishable with the user being able to see a color difference.

@alexcreasy
Copy link
Contributor Author

Thanks @vconzola, if we decide that's the route we want to go down it's a fairly straightforward change from my end

Copy link
Contributor

openshift-ci bot commented Nov 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Nov 10, 2023

New changes are detected. LGTM label has been removed.

@openshift-merge-bot openshift-merge-bot bot merged commit 358b29e into opendatahub-io:f/mserving-metrics Nov 10, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Story]: Performance metric chart needs area charts to be in a stack
2 participants