Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Caikit Serving Runtime with REST #2113

Merged

Conversation

lucferbux
Copy link
Contributor

@lucferbux lucferbux commented Nov 9, 2023

Closes #2058

Description

Support Caikit with REST

How Has This Been Tested?

  1. Deploy this template
  2. Deploy a new kserve model (I used demo-models/flan-t5-small-caikit/flan-t5-small-caikit in rhods-public)
  3. Do an inference:
> export KSVC_HOSTNAME=$(oc get ksvc <inference-name>-predictor -n <namespace> -o jsonpath='{.status.url}' | cut -d'/' -f3) 
> curl -kL -H 'Content-Type: application/json' -d '{"model_id": "flan-t5-small-caikit", "inputs": "At what temperature does Nitrogen boil?"}' https://${KSVC_HOSTNAME}/api/v1/task/text-generation

Test Impact

No automated testing

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@lucferbux lucferbux linked an issue Nov 9, 2023 that may be closed by this pull request
@lucferbux lucferbux requested review from Xaenalt and removed request for DaoDaoNoCode and dpanshug November 9, 2023 18:18
@lucferbux lucferbux added the do-not-merge/hold This PR is hold for some reason label Nov 9, 2023
@lucferbux
Copy link
Contributor Author

@Xaenalt this is the preliminary work for the issue, once we have the final image we ca review and merge this!

@lucferbux lucferbux force-pushed the issue-2058 branch 2 times, most recently from eb6bab1 to 4afc555 Compare November 10, 2023 18:44
@lucferbux lucferbux removed the do-not-merge/hold This PR is hold for some reason label Nov 10, 2023
@lucferbux
Copy link
Contributor Author

Maybe we'll need a follow up, but merging with the current images

@lucferbux
Copy link
Contributor Author

/lgtm

Copy link
Contributor

openshift-ci bot commented Nov 10, 2023

@lucferbux: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lucferbux
Copy link
Contributor Author

/approve

Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Nov 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DaoDaoNoCode, lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a9d0f1a into opendatahub-io:f/model-serving Nov 10, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Story]: Support rest calls in caikit
2 participants