Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds 'Area' support for TrustyAI and Performance Metric feature sets #2108

Merged

Conversation

alexcreasy
Copy link
Contributor

@alexcreasy alexcreasy commented Nov 8, 2023

Closes: #2088

Description

Contains the following updates:

  • Merges area features from main
  • Updates TrustyAI feature set to use area api
  • Updates Performance metrics features to use area api

How Has This Been Tested?

  • Deploy on cluster
  • Verify TrustyAI features are disabled by either flag or DSC
  • Verify Performance Metrics features are disabled by either flag or DSC

Image: quay.io/acreasy/odh-dashboard:issue-2088 can be used for deployed test.

Test Impact

N/a

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

dpanshug and others added 17 commits October 25, 2023 17:30
Bumps [aquasecurity/trivy-action](https://github.com/aquasecurity/trivy-action) from 0.11.2 to 0.13.1.
- [Release notes](https://github.com/aquasecurity/trivy-action/releases)
- [Commits](aquasecurity/trivy-action@0.11.2...0.13.1)

---
updated-dependencies:
- dependency-name: aquasecurity/trivy-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Support Truncated Model Serving Runtime Text Better
…/github_actions/main/aquasecurity/trivy-action-0.13.1

Bump aquasecurity/trivy-action from 0.11.2 to 0.13.1
…t-branches

run pull_request jobs for all branches
update branch docs to include merge pr branch naming pattern
…e-doc

include steps for merging upstream branches
…t-feature-check

Support Areas over just feature flags
@alexcreasy
Copy link
Contributor Author

I've refined the area's used by this PR and I've reverted back to keeping the biasMetricsDisabled feature flag.

@alexcreasy
Copy link
Contributor Author

/approve

Copy link
Contributor

openshift-ci bot commented Nov 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexcreasy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 9, 2023
@alexcreasy
Copy link
Contributor Author

/lgtm

Copy link
Contributor

openshift-ci bot commented Nov 9, 2023

@alexcreasy: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alexcreasy alexcreasy added the lgtm label Nov 9, 2023
@alexcreasy alexcreasy removed the request for review from christianvogt November 9, 2023 19:10
@openshift-merge-bot openshift-merge-bot bot merged commit e77d2c1 into opendatahub-io:f/mserving-metrics Nov 9, 2023
4 checks passed
@alexcreasy alexcreasy deleted the issue-2088 branch November 9, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Story]: Update f/mserving-metrics branch to work with new Area concept
6 participants