Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add migrate crd from v1alpha to v1 on start #2008

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

Gkrumbach07
Copy link
Member

@Gkrumbach07 Gkrumbach07 commented Oct 23, 2023

closes: #2007

Description

updated crd

How Has This Been Tested?

Add new CRD and make sure v1alpha versions still show up in the UI

Test Impact

backend no tests

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@Gkrumbach07 Gkrumbach07 force-pushed the version-crd branch 3 times, most recently from 93601ef to 0867e7e Compare October 23, 2023 21:48
@Gkrumbach07 Gkrumbach07 changed the title add migrate crd from v1alpha to v1 on start [WIP] add migrate crd from v1alpha to v1 on start Oct 23, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Oct 23, 2023
@Gkrumbach07 Gkrumbach07 changed the title [WIP] add migrate crd from v1alpha to v1 on start add migrate crd from v1alpha to v1 on start Oct 24, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Oct 24, 2023
@Gkrumbach07
Copy link
Member Author

cc @andrewballantyne Tested and ready for review

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 1d169b6 into opendatahub-io:main Oct 25, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Support v1alpha1 of AcceleratorProfiles
2 participants