Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Container to Step #2005

Conversation

manaswinidas
Copy link
Contributor

@manaswinidas manaswinidas commented Oct 23, 2023

Fixes #1736

Description

Renamed "Container" to "Steps".

cc @yih-wang

Screenshot 2023-10-25 at 4 59 12 PM

How Has This Been Tested?

  1. Go to Global Pipelines Run page and select any Triggered run.
  2. Click on any node -> A side drawer will appear from the right containing the "Logs" tab.
  3. You can see "Steps" instead of "Container" beside the steps-dropdown.

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@manaswinidas manaswinidas linked an issue Oct 23, 2023 that may be closed by this pull request
@manaswinidas manaswinidas linked an issue Oct 23, 2023 that may be closed by this pull request
@manaswinidas manaswinidas changed the title Rename Container to Steps Rename Container to Step Oct 25, 2023
Copy link
Member

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick search and I can't find any other usage of Container... lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 4aa5d27 into opendatahub-io:f/pipelines-enhancement Oct 25, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Terminology for Pipeline Logs
3 participants