-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ovms and add Caikit Custom Serving Runtime #1972
Update ovms and add Caikit Custom Serving Runtime #1972
Conversation
wow, very nice, thank you all |
Tested on #1969 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DaoDaoNoCode, lucferbux The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f1bb65a
into
opendatahub-io:f/model-serving
FWIW, when you need to convert a JSON blob to string -- use |
@andrewballantyne That's what I am doing in the PRs to add the annotation. |
Ah apologizes, I saw the JSON blob in my email -- didn't consider it would be for a yaml file. Nvm me! |
Closes: #1940 #1911
Description
Add support for kserve to OVMS OOTB and add Caikit as an OOTB Custom Serving Runtime
How Has This Been Tested?
oc apply -k manifests/modelserving -n <namespace>
Test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main