Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ovms and add Caikit Custom Serving Runtime #1972

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

lucferbux
Copy link
Contributor

Closes: #1940 #1911

Description

Add support for kserve to OVMS OOTB and add Caikit as an OOTB Custom Serving Runtime

How Has This Been Tested?

  1. Apply oc apply -k manifests/modelserving -n <namespace>
  2. Check that all the modeles are present in the Custom Serving Runtime page

Test Impact

  1. Not applying, it's a manifest change

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@shalberd
Copy link
Contributor

wow, very nice, thank you all

@lucferbux
Copy link
Contributor Author

Tested on #1969

manifests/modelserving/ovms-gpu-ootb.yaml Outdated Show resolved Hide resolved
manifests/modelserving/ovms-ootb.yaml Outdated Show resolved Hide resolved
manifests/modelserving/caikit-ootb.yaml Outdated Show resolved Hide resolved
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 17, 2023
@lucferbux
Copy link
Contributor Author

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DaoDaoNoCode, lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit f1bb65a into opendatahub-io:f/model-serving Oct 18, 2023
4 checks passed
@andrewballantyne
Copy link
Member

FWIW, when you need to convert a JSON blob to string -- use JSON.stringify and not manipulate it yourself. @lucferbux @DaoDaoNoCode

@DaoDaoNoCode
Copy link
Member

@andrewballantyne That's what I am doing in the PRs to add the annotation.

@andrewballantyne
Copy link
Member

Ah apologizes, I saw the JSON blob in my email -- didn't consider it would be for a yaml file. Nvm me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Story]: Migrate current Custom Serving Runtimes [Story]: Add TGIS and Caikit OOTB Serving Runtime
4 participants