-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create dashboard configuration to control kserve and modelmesh #1957
Create dashboard configuration to control kserve and modelmesh #1957
Conversation
I still need to figure out the proper way to the migration path from existing clusters, this covers the newly created clusters, might need to add some migration in the backend, we can do that as a follow up. |
I will continue the work and testuite for the migration here: #1975 |
@uidoyen If you can take a look at this too it would be amazing, thanks in advance! |
Ok, got the migration path, we need to have test coverage for that in the future, I'm gonna start a talk about that to see what the team thinks. |
Testing for this will be covered in other work. We need to verify testing infra is properly added to the backend... which may be in incubation at this point (I think it's part of the byon work if I recall correctly) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DaoDaoNoCode, lucferbux The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3eaf078
into
opendatahub-io:f/model-serving
Description
Closes #1939 #1975
Create dashboard configuration to control kserve and modelmesh enablement as model serving platforms
Work In Progress I need to figure out the upgrade path of existing clusters
How Has This Been Tested?
There are two main paths to test:
Upgrade path from an existing dashboardconfig
disableKServe
nordisableModelMesh
config
response, the dashboard is returning the following:disableKServe: true
anddisableModelMesh: false
Upgrade in a fresh cluster
dashboardConfig
CR object or just add whatever configuration you want withdisableKServe
anddisableModelMesh
config
response, the dashboard is returning the followingdisableKServe: false
anddisableModelMesh: true
Refresh an actual configuration
disableKserve: false
anddisableModelMesh: false
Test Impact
We don't have anything in place for the backend, we might need something in the future to cover migrations and so
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main