Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make data connection bucket field mandatory #1949

Merged

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented Oct 10, 2023

Closes #1583

Description

Simply made the bucket field required.

Screenshot 2023-10-10 at 1 31 13 PM

How Has This Been Tested?

  1. Go to data science project details page
  2. Create a model server
  3. Try to deploy a model, select New data connection, make sure the Bucket field is required
  4. Try to leave it as blank, make sure you cannot click deploy button

Test Impact

Add some unit tests for isAWSValid function

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@DaoDaoNoCode
Copy link
Member Author

@vconzola Can you check this very tiny change? I am not sure if it's necessary but it is a UI change, just add a small * at the end of Bucket field to indicate it's a required field.

@lucferbux
Copy link
Contributor

@DaoDaoNoCode This is just for model serving, the goal is that in the main form Bucket is not mandatory but in model serving is required. The rest looks good, great testuite.

Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isRequired should only be mandatory in model serving

@lucferbux
Copy link
Contributor

Maybe im wrong here but let me know @andrewballantyne @DaoDaoNoCode is that right?

@DaoDaoNoCode
Copy link
Member Author

@lucferbux I confirmed with @andrewballantyne, you are right, it's only required here but not everywhere.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vconzola
Copy link

vconzola commented Oct 11, 2023

@DaoDaoNoCode LGTM. Thanks for asking. ;-)

@christianvogt
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 13, 2023
@openshift-ci openshift-ci bot merged commit a9b3aae into opendatahub-io:f/model-serving Oct 13, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make bucket field mandatory in new data connection for deploy model
4 participants