Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add duplicate option for non-OOTB custom serving runtimes #1819

Merged

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented Sep 18, 2023

Closes #1499

Description

Simply add a dropdown option.

Now for OOTB custom serving runtimes:
Screenshot 2023-09-18 at 3 24 54 PM

For non-OOTB custom serving runtimes:
Screenshot 2023-09-18 at 3 25 33 PM

How Has This Been Tested?

  1. Import a new custom serving runtime or duplicate an OOTB serving runtime, to make a non-OOTB serving runtime
  2. Check the dropdown menu of the new custom serving runtime
  3. You should be able to duplicate the non-OOTB serving runtime now

Test Impact

N/A

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@DaoDaoNoCode
Copy link
Member Author

@vconzola Could you check the visual changes?

@vconzola
Copy link

vconzola commented Sep 18, 2023

@DaoDaoNoCode Can you take a screenshot of the Duplicate modal? I want to see what you're using for the modal heading and the runtime name. @kaedward is looking into inconsistencies in the current UI in similar modals and we might as well do it right the first time in this one.

@DaoDaoNoCode
Copy link
Member Author

@vconzola It's not going to a modal, it will go to a new page with the preset YAML code.

Screenshot 2023-09-18 at 3 53 16 PM

@lucferbux
Copy link
Contributor

btw @vconzola we have #1727 to fix the inconsistency of "Add" instead "Duplicate" I'm gonna take that to see if we can fix it asap

@lucferbux
Copy link
Contributor

/lgtm

Not approving until UX gives the lgtm too, I've added another comment to track the inconsistency we have right now for the "Duplicate" page.

@vconzola
Copy link

vconzola commented Sep 19, 2023

The dropdown change lgtm.

I'll add a comment to #1727 re: the wording changes.

Copy link
Contributor

@manaswinidas manaswinidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Tested. Works fine.

@lucferbux
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lucferbux, manaswinidas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 31b70b7 into opendatahub-io:main Sep 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FeatureRequest] Add option to duplicate a Custom Serving Runtime different from OOTB
5 participants