-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add duplicate option for non-OOTB custom serving runtimes #1819
Add duplicate option for non-OOTB custom serving runtimes #1819
Conversation
@vconzola Could you check the visual changes? |
@DaoDaoNoCode Can you take a screenshot of the Duplicate modal? I want to see what you're using for the modal heading and the runtime name. @kaedward is looking into inconsistencies in the current UI in similar modals and we might as well do it right the first time in this one. |
@vconzola It's not going to a modal, it will go to a new page with the preset YAML code. |
/lgtm Not approving until UX gives the lgtm too, I've added another comment to track the inconsistency we have right now for the "Duplicate" page. |
The dropdown change lgtm. I'll add a comment to #1727 re: the wording changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Tested. Works fine.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lucferbux, manaswinidas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes #1499
Description
Simply add a dropdown option.
Now for OOTB custom serving runtimes:
For non-OOTB custom serving runtimes:
How Has This Been Tested?
Test Impact
N/A
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main