Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp empty state in Model Serving Global #1796

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

lucferbux
Copy link
Contributor

Description

Closes #1091

How Has This Been Tested?

  1. Delete all Model Servers in all projects
  2. Navigate to the Model Serving global page
  3. Check that the empty state is changed
Screenshot 2023-09-18 at 15 57 21

Test Impact

Added coverage for empty state

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 18, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lucferbux. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lucferbux
Copy link
Contributor Author

@kaedward this is the end result:

Screenshot 2023-09-18 at 15 57 21

I went with a small EmptyState variant to avoid having a one liner description.

I only have one question here, the link variant for button removes the padding that was in place for the primary button, making the button to be closer to the body. Should we add some layout here or should we keep it as it is?

await page.goto(
'./iframe.html?args=&id=tests-integration-pages-modelserving-modelservingglobal--delete-model&viewMode=story',
navigateToStory('modelserving-modelservingglobal', 'empty-state-no-serving-runtime'),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just created this to open a conversation, I think @andrewballantyne mentioned this a few weeks ago, but I couldn't find any logged issue, should we include this util method to keep the navigation more consistent?

@kaedward
Copy link

@lucferbux here's some updated text for this empty state:

"No deployed models yet
To get started, deploy a model from the Models and model servers section of a project.
[Select a project]"

As for the layout questions, I'm not sure - maybe @vconzola would have an opinion :-)

@lucferbux lucferbux merged commit 2b3949d into opendatahub-io:main Sep 20, 2023
3 checks passed
@andrewballantyne
Copy link
Member

@lucferbux please recreate your PR, I have reverted this in #1834

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Create Model Server redirects to Data Science Project Screen
3 participants