Add owner references to Elyra role binding when creating notebooks #1770
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1721
Description
Check the Elyra service account role binding every time we create/restart a notebook with the enabled pipelines feature. If the role binding is there, check the
ownerReferences
field to see if the notebook is the owner, if not, patch it. If the role binding is not there, create a new one with theownerReferences
field and set the notebook as the owner. In this way, every time the user deletes the notebook, it will also delete the role binding.How Has This Been Tested?
elyra-pipelines-${workbenchName}
is created and has theownerReferences
fieldownerReferences
field in the role bindingownerReferences
field again with the new workbench uidownerReferences
field is addedTest Impact
N/A, it's about a field in role binding,
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main