-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pipelineServer #1719
Update pipelineServer #1719
Conversation
525d8b7
to
ac09997
Compare
cc @yannnz |
...nd/src/concepts/pipelines/content/configurePipelinesServer/ConfigurePipelinesServerModal.tsx
Show resolved
Hide resolved
frontend/src/concepts/pipelines/content/configurePipelinesServer/ObjectStorageSection.tsx
Outdated
Show resolved
Hide resolved
frontend/src/concepts/pipelines/content/configurePipelinesServer/ObjectStorageSection.tsx
Show resolved
Hide resolved
frontend/src/concepts/pipelines/content/configurePipelinesServer/PipelineDropdown.tsx
Show resolved
Hide resolved
frontend/src/concepts/pipelines/content/configurePipelinesServer/ObjectStorageSection.tsx
Outdated
Show resolved
Hide resolved
frontend/src/concepts/pipelines/content/configurePipelinesServer/PipelineDropdown.tsx
Outdated
Show resolved
Hide resolved
frontend/src/concepts/pipelines/content/configurePipelinesServer/PipelineDropdown.tsx
Outdated
Show resolved
Hide resolved
frontend/src/concepts/pipelines/content/configurePipelinesServer/PipelineDropdown.tsx
Outdated
Show resolved
Hide resolved
frontend/src/concepts/pipelines/content/configurePipelinesServer/PipelineDropdown.tsx
Outdated
Show resolved
Hide resolved
frontend/src/concepts/pipelines/content/configurePipelinesServer/PipelineDropdown.tsx
Outdated
Show resolved
Hide resolved
frontend/src/concepts/pipelines/content/configurePipelinesServer/ObjectStorageSection.tsx
Outdated
Show resolved
Hide resolved
frontend/src/concepts/pipelines/content/configurePipelinesServer/PipelineDropdown.tsx
Outdated
Show resolved
Hide resolved
|
99a72bd
to
7100577
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested again and it looks like you fixed the padding issues and the width is correct now |
bucket is not pulled from the data connection or shown in the dropdown menu. is this intended? |
@Gkrumbach07 referring to the Mock https://www.sketch.com/s/6c72b6b2-2c32-45ff-b07c-381d9d8c8267/a/JAamzrb , the dropdown doesnot have bucket in the list |
sounds good /lgtm |
If they have a bucket in their list, please use it. There is no reason to make them type that again. |
/lgtm |
frontend/src/concepts/pipelines/content/configurePipelinesServer/__tests__/utils.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small text issue, otherwise it looks good.
frontend/src/concepts/pipelines/content/configurePipelinesServer/ObjectStorageSection.tsx
Outdated
Show resolved
Hide resolved
@DaoDaoNoCode Thanks , I have made the changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Hey @pnaik1 - you haven't checked the box to show it's been tested with an image on a cluster, has this been done? |
@alexcreasy tested the image in the cluster and localy both are working fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well, looks good, thanks for rebasing and verifying this works deployed on a cluster.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexcreasy, DaoDaoNoCode, xianli123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes: #1214
Description
Allow for a prefill from a Data Connection for reuse of data that have already setup
separating the relationship between the Data Connection & the DSPA.
Screencast.from.2023-09-13.18-52-30.webm
4) The dropdown with bucket whenever available
How Has This Been Tested?
Test Impact
no test coverage
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main