Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pipelineServer #1719

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Conversation

pnaik1
Copy link
Contributor

@pnaik1 pnaik1 commented Aug 30, 2023

Closes: #1214

Description

Allow for a prefill from a Data Connection for reuse of data that have already setup
separating the relationship between the Data Connection & the DSPA.

Screencast.from.2023-09-13.18-52-30.webm
  1. the view pipeline server
    viewpipeline
  2. Modified the alert info in the configure pipeline modal

Screenshot from 2023-10-25 13-07-24
4) The dropdown with bucket whenever available

Screenshot from 2023-11-17 11-05-15

How Has This Been Tested?

  1. create a pipeline Server
  2. check for the prefill dataconnection dropdown ( note the dropdown appears only when the data connection are present)
  3. check whether the pipeline server is configured correctly
  4. check the view pipeline server whether the data are correctly displayed

Test Impact

no test coverage

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@pnaik1 pnaik1 added the do-not-merge/work-in-progress This PR is in WIP state label Aug 30, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Aug 30, 2023
@pnaik1 pnaik1 added the do-not-merge/work-in-progress This PR is in WIP state label Aug 30, 2023
@pnaik1 pnaik1 force-pushed the ISSUE-1214 branch 2 times, most recently from 525d8b7 to ac09997 Compare September 5, 2023 12:56
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Sep 7, 2023
@pnaik1
Copy link
Contributor Author

pnaik1 commented Sep 7, 2023

cc @yannnz

@andrewballantyne andrewballantyne added the pr/no-tests-allowed Added by an official approver - this PR is allowed no tests. Omitted, a test must accompany the PR label Sep 7, 2023
@Gkrumbach07
Copy link
Member

The dropdown is heavily squished and is missing padding visible in the mockups
image

@Gkrumbach07
Copy link
Member

Gkrumbach07 commented Sep 7, 2023

There are some UX inconsistencies in the color and weight of the non-hidden credentials
image
vs
image

The keys should be bold and the text should not be grayed

@manaswinidas manaswinidas self-assigned this Sep 8, 2023
@pnaik1 pnaik1 added the do-not-merge/work-in-progress This PR is in WIP state label Sep 11, 2023
@pnaik1
Copy link
Contributor Author

pnaik1 commented Sep 11, 2023

The dropdown is heavily squished and is missing padding visible in the mockups image
@Gkrumbach07
Just to confirm , so I can give the width properly
I agree need some width for this , but i was wondering at the screenshot you shared is it looking too squished?
My cluster is looking like this
Screenshot from 2023-09-11 18-49-47

@pnaik1 pnaik1 force-pushed the ISSUE-1214 branch 2 times, most recently from 99a72bd to 7100577 Compare September 13, 2023 10:06
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Sep 13, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Sep 16, 2023
Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit

these are all greyed instead of a pure black. is this intended, because the mocks shwo them as black not grey

image

@Gkrumbach07
Copy link
Member

Just to confirm , so I can give the width properly
I agree need some width for this , but i was wondering at the screenshot you shared is it looking too squished?
My cluster is looking like this

Tested again and it looks like you fixed the padding issues and the width is correct now

@Gkrumbach07
Copy link
Member

bucket is not pulled from the data connection or shown in the dropdown menu. is this intended?

@pnaik1
Copy link
Contributor Author

pnaik1 commented Nov 16, 2023

bucket is not pulled from the data connection or shown in the dropdown menu. is this intended?

@Gkrumbach07 referring to the Mock https://www.sketch.com/s/6c72b6b2-2c32-45ff-b07c-381d9d8c8267/a/JAamzrb , the dropdown doesnot have bucket in the list

@Gkrumbach07
Copy link
Member

@Gkrumbach07 referring to the Mock https://www.sketch.com/s/6c72b6b2-2c32-45ff-b07c-381d9d8c8267/a/JAamzrb , the dropdown doesnot have bucket in the list

sounds good

/lgtm

@andrewballantyne
Copy link
Member

If they have a bucket in their list, please use it. There is no reason to make them type that again.

@Gkrumbach07
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 17, 2023
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small text issue, otherwise it looks good.

@pnaik1
Copy link
Contributor Author

pnaik1 commented Nov 22, 2023

@DaoDaoNoCode Thanks , I have made the changes

Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 22, 2023
@alexcreasy
Copy link
Contributor

Hey @pnaik1 - you haven't checked the box to show it's been tested with an image on a cluster, has this been done?

@pnaik1
Copy link
Contributor Author

pnaik1 commented Nov 27, 2023

@alexcreasy tested the image in the cluster and localy both are working fine

@alexcreasy alexcreasy self-requested a review November 27, 2023 17:25
Copy link
Contributor

@alexcreasy alexcreasy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, looks good, thanks for rebasing and verifying this works deployed on a cluster.

/approve

Copy link
Contributor

openshift-ci bot commented Nov 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexcreasy, DaoDaoNoCode, xianli123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 8133b86 into opendatahub-io:main Nov 27, 2023
6 checks passed
@pnaik1 pnaik1 deleted the ISSUE-1214 branch July 22, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm pr/no-tests-allowed Added by an official approver - this PR is allowed no tests. Omitted, a test must accompany the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Update DSP Server - Data Connections
10 participants