Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep the enabled/disabled status after editing the custom notebook image #1436

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Keep the enabled/disabled status after editing the custom notebook image #1436

merged 1 commit into from
Jun 28, 2023

Conversation

uidoyen
Copy link
Contributor

@uidoyen uidoyen commented Jun 27, 2023 •
edited
Loading

Closes: #1434

Description

#1434 A quick fix to keep the enabled/disabled status after editing the custom notebook image

How Has This Been Tested?

ezgif-3-00918c5f7e

Test Impact

Request review criteria:

  • The commits have meaningful messages (squashes happen on merge by the bot).
  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

@openshift-ci openshift-ci bot added the needs-ok-to-test The openshift bot needs to label PRs from non members to avoid strain on the CI label Jun 27, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 27, 2023

Hi @uidoyen. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lucferbux
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test The openshift bot needs `ok-to-test` to allow non member PRs to run the tests. and removed needs-ok-to-test The openshift bot needs to label PRs from non members to avoid strain on the CI labels Jun 27, 2023
lucferbux
lucferbux approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 27, 2023
manaswinidas
manaswinidas approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@manaswinidas manaswinidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes work for me.

@andrewballantyne
Copy link
Member

/hold

cc @DaoDaoNoCode this is for your feature

@openshift-ci openshift-ci bot added the do-not-merge/hold This PR is hold for some reason label Jun 27, 2023
@uidoyen uidoyen changed the base branch from main to f/byon June 27, 2023 16:16
@andrewballantyne
Copy link
Member

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold This PR is hold for some reason label Jun 27, 2023
DaoDaoNoCode
DaoDaoNoCode reviewed Jun 27, 2023
View reviewed changes
frontend/package.json Outdated Show resolved Hide resolved
@uidoyen uidoyen changed the base branch from f/byon to main June 28, 2023 07:00
@lucferbux
Copy link
Contributor

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold This PR is hold for some reason label Jun 28, 2023
@lucferbux lucferbux removed the lgtm label Jun 28, 2023
@uidoyen uidoyen changed the base branch from main to f/byon June 28, 2023 10:02
@lucferbux
Copy link
Contributor

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold This PR is hold for some reason label Jun 28, 2023
lucferbux
lucferbux approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 28, 2023
@DaoDaoNoCode
Copy link
Member

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: lucferbux, manaswinidas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 61558a1 into opendatahub-io:f/byon Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaoDaoNoCode DaoDaoNoCode DaoDaoNoCode left review comments

@manaswinidas manaswinidas manaswinidas approved these changes

@lucferbux lucferbux lucferbux approved these changes

@alexcreasy alexcreasy Awaiting requested review from alexcreasy

@Gkrumbach07 Gkrumbach07 Awaiting requested review from Gkrumbach07

Assignees

@lucferbux lucferbux

@manaswinidas manaswinidas

@DaoDaoNoCode DaoDaoNoCode

Labels
approved lgtm ok-to-test The openshift bot needs `ok-to-test` to allow non member PRs to run the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keep the enabled/disabled status after editing the custom notebook image
6 participants
@uidoyen @lucferbux @andrewballantyne @DaoDaoNoCode @manaswinidas @openshift-merge-robot