Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipeline experiments #1406

Merged
merged 3 commits into from
Jun 27, 2023
Merged

Pipeline experiments #1406

merged 3 commits into from
Jun 27, 2023

Conversation

Gkrumbach07
Copy link
Member

closes: #1115

Description

Triggered with default experiment
image

empty experiment
image

experiment with runs
image

delete modal
image

How Has This Been Tested?

  1. create a new pipeline server
  2. create a pipeline
  3. create a experiment
  4. go to pipeline runs experiments tab and check empty state
  5. create a pipeline run and set the experiment to the one you created
  6. check that the pipeline run is populated under the correct experiment
  7. delete the experiment
  8. experiment should still be visible because the pipeline is still linked, but you can not create any runs on that experiment or delete it again
  9. clone the pipeline you created and it should default to default

Test Impact

pipelines tests are in issues

cc @kywalker-rh

Request review criteria:

  • The commits have meaningful messages (squashes happen on merge by the bot).
  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

andrewballantyne
andrewballantyne requested changes Jun 16, 2023
View reviewed changes
Copy link
Member

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. I like the design of the rendering. Left a few comments, nothing too critical or anything.

Need to test it out, this was just a code review.

frontend/src/concepts/pipelines/content/tables/experiments/ExperimentActions.tsx Outdated Show resolved Hide resolved
frontend/src/concepts/pipelines/content/tables/experiments/ExperimentsTable.tsx Outdated Show resolved Hide resolved
frontend/src/concepts/pipelines/content/tables/experiments/ExperimentsTable.tsx Show resolved Hide resolved
frontend/src/concepts/pipelines/content/tables/pipelineRun/PipelineRunTableToolbar.tsx Outdated Show resolved Hide resolved
frontend/src/concepts/pipelines/content/tables/pipelineRun/PipelineRunTableToolbar.tsx Show resolved Hide resolved
frontend/src/concepts/pipelines/content/tables/pipelineRunJob/PipelineRunJobTable.tsx Outdated Show resolved Hide resolved
frontend/src/concepts/pipelines/content/tables/pipelineRunJob/PipelineRunJobTableToolbar.tsx Outdated Show resolved Hide resolved
@andrewballantyne
Copy link
Member

Bug: if you create an experiment through the create experiment button on the experiment view... it does not auto appear. You need to navigate away and back. It should auto pop up.

@Gkrumbach07
Copy link
Member Author

new deleted expiremrnt view
image

andrewballantyne
andrewballantyne previously requested changes Jun 16, 2023
View reviewed changes
Copy link
Member

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a delete refresh issue.

  1. Create an experiment and fill it with both scheduled and triggered run
  2. Move both tabs over to experiment view
  3. Delete the experiment on one tab, navigate to the other

It doesn't say deleted

@Gkrumbach07
Copy link
Member Author

There seems to be a delete refresh issue.

I moved the experiment state to the top where the tabs meet so now each tab shares the same data.fixes a few issues with reloading too much as well

andrewballantyne
andrewballantyne reviewed Jun 19, 2023
View reviewed changes
Copy link
Member

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is looking good... will have to test it tomorrow.

@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Jun 21, 2023
@Gkrumbach07
Copy link
Member Author

PR needs rebase.

I will rebase monday

@andrewballantyne
Copy link
Member

/hold

This will need to be redirected to incubation branch when we create it tomorrow.

@openshift-ci openshift-ci bot added the do-not-merge/hold This PR is hold for some reason label Jun 22, 2023
@Gkrumbach07
revert table changes
b75a6ac
@Gkrumbach07
experiments table added
fd78824 
update linting, add label, fix create

cleaned up table logic

fixed stale data
@openshift-merge-robot openshift-merge-robot removed the needs-rebase PR needs to be rebased label Jun 26, 2023
@Gkrumbach07 Gkrumbach07 mentioned this pull request Jun 26, 2023
Closed
6 tasks
@Gkrumbach07 Gkrumbach07 changed the base branch from main to incubation June 26, 2023 13:09
@andrewballantyne
Copy link
Member

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold This PR is hold for some reason label Jun 26, 2023
@Gkrumbach07
Copy link
Member Author

/retest

@Gkrumbach07
Copy link
Member Author

/test Delete quay image on PR closed / delete-pr-quay-image (pull_request)

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 27, 2023

@Gkrumbach07: No presubmit jobs available for opendatahub-io/odh-dashboard@incubation

In response to this:

/test Delete quay image on PR closed / delete-pr-quay-image (pull_request)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andrewballantyne andrewballantyne self-requested a review June 27, 2023 20:17
@andrewballantyne andrewballantyne dismissed their stale review June 27, 2023 20:17

Because it's not refreshing on its own

@openshift-ci openshift-ci bot added the lgtm label Jun 27, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 618532c into opendatahub-io:incubation Jun 27, 2023
@Gkrumbach07 Gkrumbach07 deleted the pipeline-experiments branch August 10, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewballantyne andrewballantyne andrewballantyne approved these changes

@alexcreasy alexcreasy Awaiting requested review from alexcreasy

@DaoDaoNoCode DaoDaoNoCode Awaiting requested review from DaoDaoNoCode

Assignees

@andrewballantyne andrewballantyne

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pipelines Experiments -- Runs' Tables & Modals
3 participants
@Gkrumbach07 @andrewballantyne @openshift-merge-robot