Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Accelerator enablement in kserve is not working #2244

Closed
1 task done
lucferbux opened this issue Nov 29, 2023 · 0 comments · Fixed by #2261
Closed
1 task done

[Bug]: Accelerator enablement in kserve is not working #2244

lucferbux opened this issue Nov 29, 2023 · 0 comments · Fixed by #2261
Assignees
Labels
feature/model-serving Model Serving Feature kind/bug Something isn't working priority/blocker Critical issue that needs to be fixed asap; blocks up coming releases rhods-2.5

Comments

@lucferbux
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Deploy type

OpenDataHub core version (eg. v1.6.0)

Version

2.5.0

Current Behavior

We are currently assigning gpu resources to all the containers in a ServingRuntime spec for KServe, this has been ok for Modelmesh but it's creating an issue where we add more resources than the cluster might have.

Expected Behavior

The outcome will be the following:

For modelmesh

Keep the same flow and get the creation of InferenceServices and ServingRuntimes as it is right now

For kserve

  1. Remove the assignation of tolerations and GPU resources in the containers of the serving runtime, for that add a conditional and just add them for modelmesh.
  2. Add that logic for inferenceservices:
    • Add tolerations in spec.predictor.tolerations such as this example
    • Add the GPU resrouces in the spec.predictor-model-resources section

Steps To Reproduce

  1. Creaate a new project with accelerator
  2. Deploy a kserve model
  3. Select the maximum number of accelerator nodes

Workaround (if any)

No response

What browsers are you seeing the problem on?

No response

Anything else

No response

@lucferbux lucferbux added kind/bug Something isn't working untriaged Indicates the newly create issue has not been triaged yet priority/blocker Critical issue that needs to be fixed asap; blocks up coming releases priority/normal An issue with the product; fix when possible labels Nov 29, 2023
@lucferbux lucferbux self-assigned this Nov 29, 2023
@andrewballantyne andrewballantyne moved this from Untriaged to Dev In progress in ODH Dashboard Planning Nov 29, 2023
@github-project-automation github-project-automation bot moved this from Dev In progress to Done in ODH Dashboard Planning Dec 1, 2023
@dpanshug dpanshug removed the untriaged Indicates the newly create issue has not been triaged yet label Dec 4, 2023
@andrewballantyne andrewballantyne added feature/model-serving Model Serving Feature and removed priority/normal An issue with the product; fix when possible labels Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/model-serving Model Serving Feature kind/bug Something isn't working priority/blocker Critical issue that needs to be fixed asap; blocks up coming releases rhods-2.5
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants