Change option name for disabling Jupyter Spawner from OdhDashboardConfig CR

[bdattoma]

In order to block users from spawning jupyter notebooks from the Jupyter spawner (i.e., Dashboard > Enabled page > Jupyter tile > Launch) we can disable the notebookController option in the OdhDashboardConfig CR:

  notebookController:
    enabled: false

Users can still use workbenches (create new one, launch existing one, etc), as I think it's expected. But if I'm not wrong, the workbenches use the notebook controller too, so maybe we could change the name of the option in the CR to avoid confusion.

What do you think?

[shalberd]

But if I'm not wrong, the workbenches use the notebook controller too

@andrewballantyne Absolutely correct, a workbench in Data Science Projects creates a Notebook CR that is evaluated and managed by the kubeflow notebook controller, with additional logic later on handled by odh notebook controller.

So that option should not be called notebookController.enabled: false, maybe more like jupyterTile.enabled: false

[andrewballantyne]

Was working my way through the issues I moved from opendatahub-io/opendatahub-community repo (a generic logging spot).

Although I agree with Sven and Berto here, this is not likely something we will handle or change at this time.

We will need to rework our flags in general. We are also undergoing some rework with the new operator -- our config needs to get updated to support more component-separation model which may impact our configurations. TBD really, but doing this change is going to impact existing installations and it's going to just be a headache of moving things around while we are nearing a state of changing the dashboard config anyways (which is part of why it's still v1alpha1)

Related issues:

• [Feature Request]: Rework Feature Flags #1108
• [Tracker] Dashboard to Support Operator Rework #1475

[dgutride]

Migrated to: https://issues.redhat.com/browse/RHOAIENG-1159