Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Rework Feature Flags #1108

Closed
andrewballantyne opened this issue Apr 12, 2023 · 4 comments
Closed

[Feature Request]: Rework Feature Flags #1108

andrewballantyne opened this issue Apr 12, 2023 · 4 comments
Labels
infrastructure Anything non feature/* related that improves general working of the Dashboard kind/tech-debt A technical debt item for the development team. E.g. Refactors / Tests / etc migrated needs-info Further information is requested from the reporter or from another source priority/normal An issue with the product; fix when possible

Comments

@andrewballantyne
Copy link
Member

andrewballantyne commented Apr 12, 2023

Feature description

Our DashboardConfig is v1alpha1. I recommend we change that to v1alpha2 and rework the way our feature flags are stored.

We want to go to a highly customized structure of feature flags so things can be picked and chosen to be turned on / off.

I recommend something like:

spec:
  features:
    # ...other flags
    projects:
      enabled: boolean
      permissions: boolean
    modelServing:
      enabled: boolean
      customRuntimes: boolean
      inferenceMetrics:
        performance: boolean
        bias: boolean
      runtimeMetrics:
        performance: boolean
      overrideMetricsNamespace: string # we'd need to change the backing logic for this -- this will be another issue

(see #1109 for more on metric namespace)

There are features that are built on others -- and I think we need to look at tying them together. True here and False there, that could mean they are both False because features are dependant on each other.

We also need to talk about how features are just not going to work without other unrelated but tied in features. Projects are a huge basis of what we are doing going forward. If projects are disabled -- what then?

Describe alternatives you've considered

We keep what we have and it grows out of control slowly as we add more features related to each other.

Anything else?

No response

@andrewballantyne andrewballantyne added kind/enhancement New functionality request (existing augments or new additions) untriaged Indicates the newly create issue has not been triaged yet labels Apr 12, 2023
@github-project-automation github-project-automation bot moved this to Needs prioritization in ODH Dashboard Planning Apr 12, 2023
@Gkrumbach07 Gkrumbach07 added needs-info Further information is requested from the reporter or from another source infrastructure Anything non feature/* related that improves general working of the Dashboard and removed untriaged Indicates the newly create issue has not been triaged yet labels Apr 12, 2023
@Gkrumbach07 Gkrumbach07 moved this from Needs prioritization to Backlog in ODH Dashboard Planning Apr 12, 2023
@Gkrumbach07 Gkrumbach07 added the priority/normal An issue with the product; fix when possible label Apr 12, 2023
@andrewballantyne andrewballantyne added kind/tech-debt A technical debt item for the development team. E.g. Refactors / Tests / etc and removed kind/enhancement New functionality request (existing augments or new additions) labels May 29, 2023
@andrewballantyne andrewballantyne moved this from Backlog to To do in ODH Dashboard Planning Sep 15, 2023
@alexcreasy
Copy link
Contributor

alexcreasy commented Oct 27, 2023

Feature flags for Bias and Performance have been handled as part of their respective Trackers see:

EDIT: I think I missed the point of this ticket in my initial reading, this is about improving how flags are implemented not merely implementing them for given features.

@andrewballantyne
Copy link
Member Author

@alexcreasy Yeah, we want to rework this disable flag thing and maybe put in some dependency flags. If I recall correctly, you're placing your feature flags like the other ones... so we should be good.

@alexcreasy
Copy link
Contributor

@andrewballantyne yeah, they're just the usual: disableFeatureX: boolean style, so all good.

@dgutride dgutride added the stale Issue was created a long time ago and nothing has happened label Dec 8, 2023
@andrewballantyne andrewballantyne removed the stale Issue was created a long time ago and nothing has happened label Jan 18, 2024
@dgutride
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Anything non feature/* related that improves general working of the Dashboard kind/tech-debt A technical debt item for the development team. E.g. Refactors / Tests / etc migrated needs-info Further information is requested from the reporter or from another source priority/normal An issue with the product; fix when possible
Projects
Status: Done
Status: No status
Archived in project
Development

No branches or pull requests

4 participants