Skip to content

Commit

Permalink
Add P0 OOTB connection types
Browse files Browse the repository at this point in the history
  • Loading branch information
jeff-phillips-18 committed Oct 16, 2024
1 parent 4d29174 commit c211947
Show file tree
Hide file tree
Showing 7 changed files with 63 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@ const ConnectionTypesTableRow: React.FC<ConnectionTypesTableRowProps> = ({
{
title: 'Edit',
onClick: () => navigate(`/connectionTypes/edit/${obj.metadata.name}`),
isDisabled: ownedByDSC(obj),
},
{
title: 'Duplicate',
Expand All @@ -160,6 +161,7 @@ const ConnectionTypesTableRow: React.FC<ConnectionTypesTableRowProps> = ({
{
title: 'Delete',
onClick: () => handleDelete(obj),
isDisabled: ownedByDSC(obj),
},
]}
/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,24 @@ import { useParams } from 'react-router';
import ApplicationsPage from '~/pages/ApplicationsPage';
import { useConnectionType } from '~/concepts/connectionTypes/useConnectionType';
import { updateConnectionType } from '~/services/connectionTypesService';
import { ownedByDSC } from '~/concepts/k8s/utils';
import ManageConnectionTypePage from './ManageConnectionTypePage';

const EditConnectionTypePage: React.FC = () => {
const { name } = useParams();
const [existingConnectionType, isLoaded, error] = useConnectionType(name);

if (existingConnectionType && ownedByDSC(existingConnectionType)) {
return (

Check warning on line 14 in frontend/src/pages/connectionTypes/manage/EditConnectionTypePage.tsx

View check run for this annotation

Codecov / codecov/patch

frontend/src/pages/connectionTypes/manage/EditConnectionTypePage.tsx#L14

Added line #L14 was not covered by tests
<ApplicationsPage
loaded={isLoaded}
errorMessage="Unable to edit"
loadError={new Error('This connection type is not editable')}
empty
/>
);
}

if (!isLoaded || error) {
return <ApplicationsPage loaded={isLoaded} loadError={error} empty />;
}
Expand Down
6 changes: 6 additions & 0 deletions manifests/common/connection-types/kustomization.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
- ./oci-compliant-registry-v1.yaml
- ./s3.yaml
- ./uri-v1.yaml
14 changes: 14 additions & 0 deletions manifests/common/connection-types/oci-compliant-registry-v1.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
kind: ConfigMap
apiVersion: v1
metadata:
name: oci-compliant-registry-v1
labels:
opendatahub.io/connection-type: 'true'
opendatahub.io/dashboard: 'true'
annotations:
opendatahub.io/enabled: 'true'
openshift.io/description: 'Connect to an OCI-compliant container registry, enabling integration with containerized applications and services. Use this connection type to pull and manage container images and artifacts that adhere to the Open Container Initiative (OCI) standards, ensuring compatibility with OCI-compliant tools and workflows.'
openshift.io/display-name: OCI compliant registry - v1
data:
category: '["URI"]'
fields: '[{"type":"uri","name":"URI","envVar":"URI","required":true,"properties":{}}]'
14 changes: 14 additions & 0 deletions manifests/common/connection-types/s3.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
kind: ConfigMap
apiVersion: v1
metadata:
name: s3
labels:
opendatahub.io/connection-type: 'true'
opendatahub.io/dashboard: 'true'
annotations:
opendatahub.io/enabled: 'true'
openshift.io/description: 'Connect to storage systems that are compatible with Amazon S3, enabling integration with other S3-compatible services and applications.'
openshift.io/display-name: S3 compatible object storage - v1
data:
category: '["Object storage"]'
fields: '[{"type":"short-text","name":"Access key","envVar":"AWS_ACCESS_KEY_ID","properties":{},"required":true},{"type":"hidden","name":"Secret key","envVar":"AWS_SECRET_ACCESS_KEY","required":true,"properties":{}},{"type":"short-text","name":"Endpoint","envVar":"AWS_S3_ENDPOINT","required":true,"properties":{}},{"type":"short-text","name":"Region","envVar":"AWS_DEFAULT_REGION","required":false,"properties":{}},{"type":"short-text","name":"Bucket","envVar":"AWS_S3_BUCKET","required":false,"properties":{}},{"type":"short-text","name":"Path","envVar":"AWS_S3_PATH","properties":{}}]'
14 changes: 14 additions & 0 deletions manifests/common/connection-types/uri-v1.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
kind: ConfigMap
apiVersion: v1
metadata:
name: uri-v1
labels:
opendatahub.io/connection-type: 'true'
opendatahub.io/dashboard: 'true'
annotations:
opendatahub.io/enabled: 'true'
openshift.io/description: Establish connections by using Uniform Resource Identifiers (URIs) to access various data sources.
openshift.io/display-name: URI - v1
data:
category: '["URI"]'
fields: '[{"type":"uri","name":"URI","envVar":"URI","required":true,"properties":{}}]'
1 change: 1 addition & 0 deletions manifests/common/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ kind: Kustomization
resources:
- ./crd
- ./apps
- ./connection-types

0 comments on commit c211947

Please sign in to comment.