Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-15710] fix the version of codeflare-sdk shown for 2024.1 #771

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

jstourac
Copy link
Member

Fix the Codeflare-SDK version for the 2024.1 images.

I checked the actual Codeflare-SDK version via quay package metadata feature for images in the metadata - all that have Codeflare-SDK installed have it in version 0.21.

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@jstourac jstourac self-assigned this Nov 12, 2024
@jiridanek
Copy link
Member

/lgtm

Copy link

@ChristianZaccaria ChristianZaccaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm Thank you!

@jstourac
Copy link
Member Author

Thank you guys for a quick reviews.

We don't need to build the images for this change:

/override ci/prow/images

Let's move this on then:

/approve

Copy link
Contributor

openshift-ci bot commented Nov 12, 2024

@jstourac: Overrode contexts on behalf of jstourac: ci/prow/images

In response to this:

Thank you guys for a quick reviews.

We don't need to build the images for this change:

/override ci/prow/images

Let's move this on then:

/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Nov 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstourac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 1ab469a into opendatahub-io:main Nov 12, 2024
7 checks passed
@jstourac jstourac deleted the RHOAIENG-15710 branch November 12, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants