RHOAIENG-15242: ref(manifests): add some newlines and indentation into the json strings with package version information

[jiridanek]

https://issues.redhat.com/browse/RHOAIENG-15242

Description

Previously, we used to have every json string on a single line, which meant we had long hard-to-read lines in our manifests. Now there is some human-friendly indentation in the files so it should be easier to read.

This is to have no impact on the data stored, it is a code formatting change only.

How Has This Been Tested?

I've ran the sample code from a comment on https://issues.redhat.com/browse/RHOAIENG-15333 that extracts and formats the installed software fields as a Markdown table. I then compared the outputs before and after this change, and looked for differences.

poetry run ci/package_versions.py > after.md
poetry run ci/package_versions.py > before.md
diff before.md after.md

Then I took the manifests and deployed them on some cluster

oc login --web
cd manifests/base
../../kustomize-5.0.2 edit set namespace redhat-ods-application
../../kustomize-5.0.2 edit set nameprefix main-
../../kustomize-5.0.2 build . | oc apply -f -

and then I also remembered to do it with overlays/additional images.

Merge criteria:

• The commits are squashed in a cohesive manner and have meaningful messages.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[jstourac]

/lgtm

[atheo89]

/lgtm

However, I was checking the test instructions and you mentioned this:

poetry run ci/package_versions.py > after.md
poetry run ci/package_versions.py > before.md
diff before.md after.md

What are you talking about? Did i miss something? I search for package_versions.py on your fork and it is not there a sucj file 🤔

[caponetto]

/lgtm TY!

[jiridanek]

What are you talking about? Did i miss something? I search for package_versions.py on your fork and it is not there a such file 🤔

It's in a comment in a Jira,

I've ran the sample code from a comment on https://issues.redhat.com/browse/RHOAIENG-15333 that extracts and formats the installed software fields as a Markdown table.

[jiridanek]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jiridanek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jiridanek]

/override ci/prow/images
rocm images failed to build, same old

[openshift-ci]

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images

In response to this:

/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.