Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-2003: feat(metadata/codeserver): update VSCode imagestream annotations with installed software #756

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented Oct 29, 2024

https://issues.redhat.com/browse/RHOAIENG-2003

Description

Took into account the good suggestions from https://issues.redhat.com/browse/RHOAIRFE-320 as well.

I've also added the # language=json injection comment described at https://www.jetbrains.com/help/idea/using-language-injections.html#use-language-injection-comments. If there's something similar for people using different IDEs, we can change it for something more portable later.

Finally, I put some newlines into the annotation, to make it easier for people to read it.

Screenshot 2024-10-29 at 1 53 18 PM

How Has This Been Tested?

I'm going to run Kustomize, copy out the rendered manifest, rename it, and put it into my cluster. Then I'll check in the dashboard how it renders.

oc login --web
cd manifests/base
../../kustomize-5.0.2 edit set namespace redhat-ods-application
../../kustomize-5.0.2 edit set nameprefix main-
../../kustomize-5.0.2 build . | oc apply -f -

Screenshot 2024-10-29 at 4 53 35 PM

Screenshot 2024-10-29 at 4 52 58 PM

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@jiridanek jiridanek force-pushed the jd_update_codeserver_annotations branch 4 times, most recently from 3c1404d to 67ccd8f Compare October 29, 2024 13:06
ci/check-json.sh Outdated Show resolved Hide resolved
@jiridanek jiridanek force-pushed the jd_update_codeserver_annotations branch 2 times, most recently from 566b923 to dff303d Compare October 29, 2024 14:13
@jstourac
Copy link
Member

@jiridanek thank you for this and thank you for enhancing/fixing the CI for this change.

In general this LGTM and I put just one comment regarding the addition of the UBI information here. I don't insist on the removal but I think we should consider it.

@jiridanek jiridanek force-pushed the jd_update_codeserver_annotations branch from dff303d to 01f4e64 Compare October 29, 2024 15:24
@atheo89
Copy link
Member

atheo89 commented Oct 30, 2024

Great representation by using the # language=json, imo, we should do the same to the rest of the ImageStreams to keep consistency.
/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Oct 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiridanek
Copy link
Member Author

/override ci/prow/images

rocm failed to build

Copy link
Contributor

openshift-ci bot commented Oct 31, 2024

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images

In response to this:

/override ci/prow/images

rocm failed to build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit e071465 into opendatahub-io:main Oct 31, 2024
7 checks passed
@jiridanek
Copy link
Member Author

we should do the same to the rest of the ImageStreams to keep consistency.

absolutely, filled task https://issues.redhat.com/browse/RHOAIENG-15242

@jiridanek jiridanek deleted the jd_update_codeserver_annotations branch October 31, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants