Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unncessary one-time workaround from the digest updater GHA #738

Merged

Conversation

jstourac
Copy link
Member

@jstourac jstourac commented Oct 5, 2024

This change was never intended to be merged as it was marked with the DONT COMMIT message in the draft PR. Since it got merged and the GHA has been executed updating the base images for the new N (2024b) version, we can safely remove this workaround now.

This is a followup of #716.

Note: I presume that 2024b branch manifests in this opendatahub-io org will be updated by merging changes from main to 2024b, correct? 🤔 @harshad16 If not, then this should stay open until this GHA is run over the 2024b branch also.

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

This change was never intended to be merged as it was marked with the
DONT COMMIT message in the draft PR. Since it got merged and the GHA has
been executed updating the base images for the new N (2024b) version, we
can safely remove this workaround now.
@jstourac jstourac self-assigned this Oct 5, 2024
@jiridanek
Copy link
Member

/lgtm

@jiridanek
Copy link
Member

/override ci/prow/images

Copy link
Contributor

openshift-ci bot commented Oct 7, 2024

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images

In response to this:

/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jstourac
Copy link
Member Author

jstourac commented Oct 7, 2024

Note: I presume that 2024b branch manifests in this opendatahub-io org will be updated by merging changes from main to 2024b, correct? 🤔 @harshad16 If not, then this should stay open until this GHA is run over the 2024b branch also.

Actually, it depends what branch we will use for the manifest reference... probably main is used for the ODH, in which case, we don't care about the manifests content in 2024b branch?

@jstourac
Copy link
Member Author

jstourac commented Oct 9, 2024

Note: I presume that 2024b branch manifests in this opendatahub-io org will be updated by merging changes from main to 2024b, correct? 🤔 @harshad16 If not, then this should stay open until this GHA is run over the 2024b branch also.

Actually, it depends what branch we will use for the manifest reference... probably main is used for the ODH, in which case, we don't care about the manifests content in 2024b branch?

This was confirmed on Monday meeting.

@jstourac
Copy link
Member Author

jstourac commented Oct 9, 2024

Since this is just a GHA change, I'll go ahead with just one lgtm.

/approve

Copy link
Contributor

openshift-ci bot commented Oct 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstourac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 9, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit d2c43f2 into opendatahub-io:main Oct 9, 2024
7 checks passed
@jstourac jstourac deleted the removeTmpWorkaround branch October 9, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants