-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unncessary one-time workaround from the digest updater GHA #738
Remove unncessary one-time workaround from the digest updater GHA #738
Conversation
This change was never intended to be merged as it was marked with the DONT COMMIT message in the draft PR. Since it got merged and the GHA has been executed updating the base images for the new N (2024b) version, we can safely remove this workaround now.
/lgtm |
/override ci/prow/images |
@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Actually, it depends what branch we will use for the manifest reference... probably |
This was confirmed on Monday meeting. |
Since this is just a GHA change, I'll go ahead with just one lgtm. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jstourac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This change was never intended to be merged as it was marked with the DONT COMMIT message in the draft PR. Since it got merged and the GHA has been executed updating the base images for the new N (2024b) version, we can safely remove this workaround now.
This is a followup of #716.
Note: I presume that 2024b branch manifests in this opendatahub-io org will be updated by merging changes from main to 2024b, correct? 🤔 @harshad16 If not, then this should stay open until this GHA is run over the 2024b branch also.
Description
How Has This Been Tested?
Merge criteria: