-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Notebook with codeflare-sdk version 0.21.1 #725
Upgrade Notebook with codeflare-sdk version 0.21.1 #725
Conversation
Signed-off-by: Harshad Reddy Nalla <[email protected]>
/lgtm |
/retest-required |
@harshad16, are these skipped intentionally? Not touching any intel ones?
|
yes @jstourac |
Great, thanks for confirmation, Harshad. In that case /lgtm for this one. As such, should we ignore python 3.9 and intel based images in the GHA from the codeflare sdk repository? |
|
Thanks for all the review /approve /override ci/prow/images |
@harshad16: Overrode contexts on behalf of harshad16: ci/prow/images, ci/prow/notebook-rocm-jupyter-pyt-ubi9-python-3-11-pr-image-mirror, ci/prow/notebooks-ubi9-e2e-tests, ci/prow/rocm-notebooks-e2e-tests, ci/prow/rocm-runtimes-ubi9-e2e-tests, ci/prow/runtimes-ubi9-e2e-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@harshad16 Also can you include this |
@Srihari1192 all the work would be moved today to release branch. |
Description
Upgrade Notebook with codeflare-sdk version 0.21.1
Fixes: #719
As the github action failed: https://github.com/project-codeflare/codeflare-sdk/actions/runs/11134262380
How Has This Been Tested?
NA
Merge criteria: