-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all images and Makefile calls to Python 3.8 #703
Remove all images and Makefile calls to Python 3.8 #703
Conversation
Skipping CI for Draft Pull Request. |
0366501
to
b282d8d
Compare
b282d8d
to
e232222
Compare
Thank you Daniel for this clean up!! 🙂 Otherwise /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
On top of what Adriana proposed, maybe we could also fix proper version in these:
But since there is a discussion whether we shouldn't remove the 3.9 from this branch also, so probably not worth of any effort. Moreover, there are still some other references to UBI8, but it's probably not that important as it's usually used as an example value in our docs. So, feel free to ignore this comment 😀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Co-authored-by: Jan Stourac <[email protected]>
3e52102
to
b546862
Compare
/lgtm |
/override ci/prow/runtimes-ubi8-e2e-tests |
@atheo89: Overrode contexts on behalf of atheo89: ci/prow/notebook-jupyter-datascience-ubi8-python-3-8-pr-image-mirror, ci/prow/notebook-jupyter-minimal-ubi8-python-3-8-pr-image-mirror, ci/prow/notebooks-ubi8-e2e-tests, ci/prow/runtime-cuda-tensorflow-ubi8-python-3-8-pr-image-mirror, ci/prow/runtime-datascience-ubi8-python-3-8-pr-image-mirror, ci/prow/runtime-minimal-ubi8-python-3-8-pr-image-mirror, ci/prow/runtime-pytorch-ubi8-python-3-8-pr-image-mirror, ci/prow/runtimes-ubi8-e2e-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override ci/prow/anaconda-ubi8-e2e-tests |
@atheo89: Overrode contexts on behalf of atheo89: ci/prow/anaconda-ubi8-e2e-tests, ci/prow/habana-notebooks-e2e-tests, ci/prow/images, ci/prow/jupyter-datascience-anaconda-python-3-8-pr-image-mirror, ci/prow/notebook-base-ubi8-python-3-8-pr-image-mirror, ci/prow/notebook-cuda-jupyter-ds-ubi8-python-3-8-pr-image-mirror, ci/prow/notebook-cuda-jupyter-minimal-ubi8-python-3-8-pr-image-mirror, ci/prow/notebook-habana-1-10-0-ubi8-python-3-8-pr-image-mirror, ci/prow/notebook-habana-1-13-0-ubi8-python-3-8-pr-image-mirror In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override ci/prow/notebook-cuda-ubi8-python-3-8-pr-image-mirror |
@atheo89: Overrode contexts on behalf of atheo89: ci/prow/notebook-cuda-ubi8-python-3-8-pr-image-mirror In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
6542483
into
opendatahub-io:main
JFYI - I think that this one wasn't updated. |
Related to: https://issues.redhat.com/browse/RHOAIENG-12625
As 2024b branch is coming to development, all images based on Python 3.8 will be dropped, as Python 3.8 will only be supported on 2023b branch and for Habana based images that require support for them.
Description
All Python 3.8 based images need to be removed, as 2024b branch will not provide support anymore, only on branch 2023b.
This will involve the removal of the following images:
Also the image calls need to be removed from the Makefile, the CI matrix and any other places that reference to Python 3.8.
How Has This Been Tested?
Merge criteria: