Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Codeflare Action] Update notebook's pipfile to sync with Codeflare-SDK release 0.19.1 #675

Merged

Conversation

codeflare-machine-account
Copy link
Contributor

🚀 This is an automated Pull Request.

This PR updates the Pipfile to sync with latest Codeflare-SDK release.

@jstourac
Copy link
Member

/lgtm

we need to update the imagestreams definitions to comply with the codeflare package upgrade

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
👍

Copy link
Contributor

openshift-ci bot commented Aug 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Aug 16, 2024

@codeflare-machine-account: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/notebook-jupyter-pytorch-ubi9-python-3-9-pr-image-mirror c8422b2 link true /test notebook-jupyter-pytorch-ubi9-python-3-9-pr-image-mirror
ci/prow/runtime-rocm-tensorflow-ubi9-python-3-9-pr-image-mirror c8422b2 link true /test runtime-rocm-tensorflow-ubi9-python-3-9-pr-image-mirror
ci/prow/rocm-runtimes-ubi9-e2e-tests c8422b2 link true /test rocm-runtimes-ubi9-e2e-tests
ci/prow/runtimes-ubi9-e2e-tests c8422b2 link true /test runtimes-ubi9-e2e-tests
ci/prow/rocm-notebooks-e2e-tests c8422b2 link true /test rocm-notebooks-e2e-tests
ci/prow/notebooks-ubi9-e2e-tests c8422b2 link true /test notebooks-ubi9-e2e-tests
ci/prow/images c8422b2 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@caponetto
Copy link
Contributor

@harshad16 Can this automated job be re-run so that the updates are done for the Python 3.11 images as well?

@harshad16
Copy link
Member

@guimou This workflow is in codeflare-sdk project. We can ask them if we want to rerun this.

however as we are not shipping python 3.11 as of now
i believe we can wait for the next release, which would anyhow would get those changes.
we are few months away for getting 3.11.

another note, we haven't done package updates in the 3.11 , so that process would also take care of it.
Let me know , if you feel otherwise, we can reach out to that team for rerun.

@caponetto
Copy link
Contributor

@guimou This workflow is in codeflare-sdk project. We can ask them if we want to rerun this.

however as we are not shipping python 3.11 as of now i believe we can wait for the next release, which would anyhow would get those changes. we are few months away for getting 3.11.

another note, we haven't done package updates in the 3.11 , so that process would also take care of it. Let me know , if you feel otherwise, we can reach out to that team for rerun.

Sounds good to me! I just wanted to keep everything in sync.
Nevertheless, the changes are not complex, we can apply them manually if necessary.

@harshad16 harshad16 merged commit 97172ba into opendatahub-io:main Aug 18, 2024
27 of 35 checks passed
jstourac added a commit to jstourac/notebooks that referenced this pull request Aug 19, 2024
@jstourac
Copy link
Member

/lgtm

we need to update the imagestreams definitions to comply with the codeflare package upgrade

I have created the #679.

Also, the updater workflow ignores the Pipfile.cpu and Pipfile.gpu files in the intel directories so I raised project-codeflare/codeflare-sdk#644 - will be probably migrated to a jira issue 🤷

jstourac added a commit to jstourac/notebooks that referenced this pull request Aug 20, 2024
harshad16 pushed a commit that referenced this pull request Aug 26, 2024
daniellutz pushed a commit to daniellutz/odh-notebooks that referenced this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants