-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade codeflare-sdk 0.18.0 for py3.9 content #646
Upgrade codeflare-sdk 0.18.0 for py3.9 content #646
Conversation
Signed-off-by: Harshad Reddy Nalla <[email protected]> Co-authored-by: Jan Stourac <[email protected]>
Skipping CI for Draft Pull Request. |
FTR: https://issues.redhat.com/browse/RHOAIENG-10666 Python package diff for the
The diff seems okay to me. Also, all the relevant files are updated in this PR, so also good. I would consider to have the dependency fix in a separate commit than the actual codeflare-sdk upgrade. But I can live with that. /lgtm |
/lgtm |
As we would have to retrigger a workflow , which isn't on our end, this is more of convenience way. |
Thanks for the review folks. /override ci/prow/rocm-notebooks-e2e-tests |
@harshad16: Overrode contexts on behalf of harshad16: ci/prow/images, ci/prow/notebooks-ubi9-e2e-tests, ci/prow/rocm-notebooks-e2e-tests, ci/prow/runtimes-ubi9-e2e-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jstourac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -15,6 +15,7 @@ name = "pytorch" | |||
tensorboard = "~=2.16.2" | |||
torch = {version = "~=2.3.1", index = "pytorch"} | |||
torchvision = {version = "~=0.18.1", index = "pytorch"} # https://pytorch.org/get-started/previous-versions/#linux-and-windows-1 | |||
pytorch-triton-rocm = {version = "~=2.3.1", index = "pytorch"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized that this added line should be added also into the runtimes/rocm-pytorch/ubi9-python-3.9/Pipfile
. I addressed this during some other work in #656. Shall we amend this PR with this addition before this is merged or are we okay with the fix in the followup PR? 🤔
Description
Upgrade codeflare-sdk 0.18.0 for py3.9 content
Fixes: https://github.com/project-codeflare/codeflare-sdk/actions/runs/10114395555/job/27972928826
JIRA: https://issues.redhat.com/browse/RHOAIENG-10666
Neglected:
How Has This Been Tested?
CI tests
Merge criteria: