Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-9168: Remove unused images from notebooks repo #621

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

paulovmr
Copy link
Contributor

@paulovmr paulovmr commented Jul 16, 2024

Description

This PR removes the following unused images:

  • jupyter-trustyai-ubi8-python-3.8
  • habana-jupyter-1.9.0-ubi8-python-3.8
  • habana-jupyter-1.11.0-ubi8-python-3.8

It also adds the following image directories that were missing to the refresh-pipfilelock-files command:

  • habana/1.10.0/ubi8-python-3.8
  • habana/1.13.0/ubi8-python-3.8
  • runtimes/minimal/ubi8-python-3.8
  • runtimes/minimal/ubi9-python-3.9

From those images, only the jupyter-trustyai-ubi8-python-3.8 had CI jobs defined, which are being removed here.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@jiridanek jiridanek added the lgtm label Jul 17, 2024
Copy link
Member

@atheo89 atheo89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Paulo for the clean up!

/lgtm

Copy link
Contributor

openshift-ci bot commented Jul 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jul 18, 2024

@paulovmr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/notebook-jupyter-trustyai-ubi8-python-3-8-pr-image-mirror f3a9caf link true /test notebook-jupyter-trustyai-ubi8-python-3-8-pr-image-mirror

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jstourac
Copy link
Member

/lgtm

@paulovmr
Copy link
Contributor Author

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit cdbf086 into opendatahub-io:main Jul 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants