Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OWNERS file with adding more approvers #611

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Update OWNERS file with adding more approvers #611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b5cd75
Update OWNERS file with adding more approvers
jstourac Jul 9, 2024
6da0818
update the contributing guide
jstourac Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,3 +56,8 @@ Pull requests are the best way to propose changes to the notebooks repository:
### Testing your PR locally

- Test the changes locally, by manually running the `$make jupyter-${NOTEBOOK_NAME}-ubi8-python-3.8` from the terminal. This definitely helps in that initial phase.

### Review and Merge Process

- Once the PR is submitted, you can either select specific reviewers or let the bot to select reviewers [automatically](https://prow.ci.openshift.org/plugins?repo=opendatahub-io%2Fnotebooks).
- For the PR to be merged, it must receive 2 reviews from the repository [approvals/reviewers](/OWNERS). Following that, an `/approve` comment must be added by someone with approval rights. If the author of the PR has approval rights, it is preferred that they perform the merge action.
4 changes: 4 additions & 0 deletions OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
approvers:
- atheo89
- caponetto
- harshad16
- jiridanek
- jstourac
- paulovmr

reviewers:
- atheo89
Expand Down