Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-1249: Bump requests lib to 2.31.0 #608

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

caponetto
Copy link
Contributor

https://issues.redhat.com/browse/RHOAIENG-1249

Description

Bump requests lib to 2.31.0 as suggested by Snyk.

Note: Pipfiles are already using this version.

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Contributor

openshift-ci bot commented Jul 5, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@caponetto caponetto marked this pull request as ready for review July 5, 2024 16:30
@openshift-ci openshift-ci bot requested review from harshad16 and paulovmr July 5, 2024 16:30
@caponetto
Copy link
Contributor Author

/retest

@atheo89
Copy link
Member

atheo89 commented Jul 8, 2024

/lgtm Thanks for the upgrade!

About the failed test, it appears that fall on the second case at this time... (Need to check/fix it in the future to have all test pass)
FWI: #562

@atheo89 atheo89 added the lgtm label Jul 8, 2024
@caponetto
Copy link
Contributor Author

caponetto commented Jul 8, 2024

Thanks for the info @atheo89!

BTW this bump should be fine since now there is a match between the versions of requests dependency on Pipfile and requirements-elyra.txt.

@atheo89
Copy link
Member

atheo89 commented Jul 9, 2024

/override ci/prow/intel-notebooks-e2e-tests

Copy link
Contributor

openshift-ci bot commented Jul 9, 2024

@atheo89: Overrode contexts on behalf of atheo89: ci/prow/intel-notebooks-e2e-tests

In response to this:

/override ci/prow/intel-notebooks-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Jul 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jiridanek, paulovmr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiridanek
Copy link
Member

/retest
failures don't make much sense to me, lets try again

@caponetto
Copy link
Contributor Author

/retest

@jiridanek
Copy link
Member

@atheo89 can you please redo this, I guess?
/override ci/prow/intel-notebooks-e2e-tests

Copy link
Contributor

openshift-ci bot commented Jul 10, 2024

@jiridanek: jiridanek unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:.

In response to this:

@atheo89 can you please redo this, I guess?
/override ci/prow/intel-notebooks-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@atheo89
Copy link
Member

atheo89 commented Jul 11, 2024

/override ci/prow/intel-notebooks-e2e-tests

Copy link
Contributor

openshift-ci bot commented Jul 11, 2024

@atheo89: Overrode contexts on behalf of atheo89: ci/prow/intel-notebooks-e2e-tests

In response to this:

/override ci/prow/intel-notebooks-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@atheo89
Copy link
Member

atheo89 commented Jul 11, 2024

/test runtimes-ubi8-e2e-tests

1 similar comment
@jiridanek
Copy link
Member

/test runtimes-ubi8-e2e-tests

@jiridanek
Copy link
Member

/test runtimes-ubi9-e2e-tests

@jiridanek
Copy link
Member

/override ci/prow/intel-notebooks-e2e-tests

Copy link
Contributor

openshift-ci bot commented Jul 12, 2024

@jiridanek: jiridanek unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:.

In response to this:

/override ci/prow/intel-notebooks-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@atheo89
Copy link
Member

atheo89 commented Jul 12, 2024

/override ci/prow/intel-notebooks-e2e-tests
huh

Copy link
Contributor

openshift-ci bot commented Jul 12, 2024

@atheo89: Overrode contexts on behalf of atheo89: ci/prow/intel-notebooks-e2e-tests

In response to this:

/override ci/prow/intel-notebooks-e2e-tests
huh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 079199a into opendatahub-io:main Jul 12, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants