-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated image manifests with AMD images for pytorch and tensorflow #593
Conversation
/hold till this get merged #557 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I left some comments!
manifests/overlays/additional/jupyter-amd-pytorch-notebook-imagestream.yaml
Outdated
Show resolved
Hide resolved
manifests/overlays/additional/jupyter-amd-tensorflow-notebook-imagestream.yaml
Outdated
Show resolved
Hide resolved
manifests/overlays/additional/jupyter-amd-pytorch-notebook-imagestream.yaml
Outdated
Show resolved
Hide resolved
/retest |
manifests/overlays/additional/jupyter-amd-pytorch-notebook-imagestream.yaml
Outdated
Show resolved
Hide resolved
manifests/overlays/additional/jupyter-amd-pytorch-notebook-imagestream.yaml
Outdated
Show resolved
Hide resolved
/retest-required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as we are not yet ready to release this images
probably it would be best to get ready.
we need to move this to base:
- Place an env var for build-commit:
notebooks/manifests/overlays/additional/jupyter-rocm-pytorch-notebook-imagestream.yaml
Line 23 in 3bbbf84
opendatahub.io/notebook-build-commit: 'c010eb0'
set this in the commit.yaml and commit.env - Place an env var for name:
notebooks/manifests/overlays/additional/jupyter-rocm-pytorch-notebook-imagestream.yaml
Line 26 in 3bbbf84
name: quay.io/opendatahub/workbench-images@sha256:99e4822a580e8687f178e772af6b3dea507b50b4023792aa2dea0c2475c74ba6
set this in the param.yaml and param.env
without changing the kustomization.yaml, so we don't have them deployed.
Examples:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, some changes are needed
manifests/base/jupyter-rocm-tensorflow-notebook-imagestream.yaml
Outdated
Show resolved
Hide resolved
manifests/base/jupyter-rocm-tensorflow-notebook-imagestream.yaml
Outdated
Show resolved
Hide resolved
3e32e2c
to
8694c69
Compare
280719f
to
3beba31
Compare
9d95d9a
to
cc8572b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes needed
1dcb3e1
to
3eb30b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For fixing the validation check, i believe following changes are needed
PTAL
f706ef5
to
87ad31a
Compare
@dibryant: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
thanks 👍
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override ci/prow/rocm-notebooks-e2e-tests |
@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/rocm-notebooks-e2e-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5573f26
into
opendatahub-io:main
Fixes for https://issues.redhat.com/browse/RHOAIENG-4368
Description
Updated imagestream for AMD pytorch and tensorflow for users that want OOTB workbench images with AMD libraries & package
How Has This Been Tested?
Merge criteria: