Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2024a] [CI] Enhance params env check script #575

Merged
merged 3 commits into from
Jun 21, 2024
Merged

[2024a] [CI] Enhance params env check script #575

merged 3 commits into from
Jun 21, 2024

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #567

/assign jiridanek

/cherrypick 2023b 2023a

@jstourac
let's run params-env workflow also on push
7c154ab 
Let's run the params-env workflow that checks values in params.env
and commit.env files also on push event and also on dispatch_workflow.
@jstourac
enhance the check-params-env.sh to also check uniqueness of values
9e23cd6 
Up to now, it only checked that variables used in params.env file are
unique. This change checks also that the images referenced are unique as
we don't expect any of the given variables to hold the same reference.
@jstourac
check-params-env.sh prints also time of creation of the checked image
7276dc6
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 19, 2024
Merged
3 tasks
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 19, 2024

Hi @openshift-cherrypick-robot. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jiridanek
Copy link
Member 

Checking format of: 'odh-rstudio-notebook-image-n=quay.io/opendatahub/workbench-images@sha256:d5df31b1bc1e2f8b38d558d9f13c2926665d09237feabaaef94dc3574d613f0d'
Checking metadata for image 'odh-rstudio-notebook-image-n' with URL 'quay.io/opendatahub/workbench-images@sha256:d5df31b1bc1e2f8b38d558d9f13c2926665d09237feabaaef94dc3574d613f0d'
Image name retrieved: 'odh-notebook-rstudio-server-c9s-python-3.9'
Image created: '2024-05-23T17:16:00.755830268Z'
Image URL points to an incorrect image: expected OPENSHIFT_BUILD_NAME 'rstudio-c9s-python-3.9-amd64'; actual 'cuda-rstudio-c9s-python-3.9-amd64'
ERROR: Image definition for 'odh-rstudio-notebook-image-n' isn't okay!

https://github.com/opendatahub-io/notebooks/actions/runs/9587223228/job/26436804531?pr=575#step:4:102

@jiridanek jiridanek requested a review from atheo89 June 19, 2024 19:29
jiridanek
jiridanek approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@jiridanek jiridanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 19, 2024
@jstourac
Copy link
Member

Yeah, IMHO the failure is genuine: https://quay.io/repository/opendatahub/workbench-images/manifest/sha256:d5df31b1bc1e2f8b38d558d9f13c2926665d09237feabaaef94dc3574d613f0d

@harshad16
Copy link
Member

Thanks for the wonderful PR
/approve

@harshad16 harshad16 merged commit 71248ea into opendatahub-io:2024a Jun 21, 2024
31 of 33 checks passed
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16, jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiridanek jiridanek jiridanek approved these changes

@dibryant dibryant Awaiting requested review from dibryant

@harshad16 harshad16 Awaiting requested review from harshad16

@atheo89 atheo89 Awaiting requested review from atheo89

Assignees

@jiridanek jiridanek

Labels
approved lgtm ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@openshift-cherrypick-robot @jiridanek @jstourac @harshad16