Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new team members on the reviewer list #561

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented Jun 14, 2024

Description

This PR adds the new team members to the reviewers list on notebooks repo.

Welcome folks :)

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

- dibryant
- harshad16
- jiridanek
- jstourac
- paulovmr
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just checking we have the correct account names here, @caponetto @paulovmr; anyways, if they weren't members of @opendatahub-io, the bot would alert us, so all should be good

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are correct, thank you :)

Copy link
Contributor

openshift-ci bot commented Jun 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: caponetto, jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b1031b9 into opendatahub-io:main Jun 14, 2024
32 checks passed
This was referenced Jul 18, 2024
@atheo89 atheo89 deleted the update-owners branch October 23, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants