Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with Run and Debug on code-server workbench #556

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

atheo89
Copy link
Member

@atheo89 atheo89 commented Jun 12, 2024

Related to: https://issues.redhat.com/browse/RHOAIENG-2312

Description

This PR addresses an issue where users were unable to use the Run and Debug button in the code-server workbench to execute a Python file.

The fix involves adding a launch.json configuration to the .vscode directory. This configuration ensures that the debugger uses the correct Python interpreter, specifically /opt/app-root/bin/python3, which includes pre-installed packages such as numpy.

How Has This Been Tested?

  1. PR code-server built image quay.io/opendatahub/workbench-images@sha256:a25623900cdd8e50135bf618cc231061c1e7a970caa96cd8c880ba596a8cc7cb
  • Replace the code-server:2024.1 image hash with the image from this PR,
  • OR import the PR image from ODH dashboard -> Settings ->Notebook Images -> Import new image and use the newly imported image to spin up the code-server notebook.
  1. Reproduce the steps as shown on the video below:
    Screencast from 2024-06-12 14-13-59.webm

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@atheo89 atheo89 force-pushed the python-path branch 3 times, most recently from 318a659 to f62a8dd Compare June 12, 2024 14:23
@jiridanek
Copy link
Member

I'm checking ghcr.io/atheo89/notebooks/workbench-images:codeserver-ubi9-python-3.9-python-path_1fb7f571f21326f557fa04743d84c43d7336e2b4 from https://github.com/atheo89/notebooks/actions/runs/9484866920/job/26135476419

It appears to work fine now.

/lgtm

@atheo89
Copy link
Member Author

atheo89 commented Jun 13, 2024

/override ci/prow/notebooks-e2e-tests
/approve

Copy link
Contributor

openshift-ci bot commented Jun 13, 2024

@atheo89: Overrode contexts on behalf of atheo89: ci/prow/notebooks-e2e-tests

In response to this:

/override ci/prow/notebooks-e2e-tests
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Jun 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atheo89, jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 2c36c11 into opendatahub-io:main Jun 13, 2024
34 checks passed
@atheo89 atheo89 deleted the python-path branch October 23, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants