Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend CI image check to also runtime images #522

Merged
merged 1 commit into from
May 21, 2024

Conversation

jstourac
Copy link
Member

@jstourac jstourac commented May 9, 2024

Description

Extens the CI check for the images we reference in our metadata to also runtime-images.

https://issues.redhat.com/browse/RHOAIENG-7882

How Has This Been Tested?

Simply run: ./ci/check-runtime-images.sh on your local machine (jq and skopeo tool needed).

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Contributor

openshift-ci bot commented May 13, 2024

@jstourac: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/notebooks-e2e-tests 29b1188 link true /test notebooks-e2e-tests
ci/prow/images 29b1188 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jstourac
Copy link
Member Author

Hi guys, any opinions? Can this be moved forward so we have this check in our next release branch? Thanks for any comments or proposals for improvements! 🙂

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great 💯
Thanks

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented May 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harshad16 harshad16 merged commit 97b3362 into opendatahub-io:main May 21, 2024
1 of 6 checks passed
@jstourac jstourac deleted the checkRuntimeImgMetadata branch May 22, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants