Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Codeflare Action] Update notebook's pipfile to sync with Codeflare-SDK release 0.16.0 #512

Merged

Conversation

codeflare-machine-account
Copy link
Contributor

🚀 This is an automated Pull Request.

This PR updates the Pipfile to sync with latest Codeflare-SDK release.

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
thanks 💯

Copy link
Contributor

openshift-ci bot commented Apr 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Apr 19, 2024

@codeflare-machine-account: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/habana-notebooks-e2e-tests 18e7891 link true /test habana-notebooks-e2e-tests
ci/prow/notebooks-e2e-tests 18e7891 link true /test notebooks-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jstourac
Copy link
Member

jstourac commented Apr 22, 2024

@jstourac
Copy link
Member

BTW - each update like this also requires update in metadata for the affected image version of image streams that contain the codeflare-sdk installed. Right now its these lines:

I wonder whether it would make sense to make these changes part of the PRs like this already?

@harshad16
Copy link
Member

ack, we would do the imagestream annotation update in a separate PR.
Merging this now.

@harshad16 harshad16 merged commit bf358c8 into opendatahub-io:main Apr 23, 2024
19 of 22 checks passed
@jstourac
Copy link
Member

@harshad16 in such case, please link it with this one issue https://issues.redhat.com/browse/RHOAIENG-6271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants