-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Codeflare Action] Update notebook's pipfile to sync with Codeflare-SDK release 0.16.0 #512
[Codeflare Action] Update notebook's pipfile to sync with Codeflare-SDK release 0.16.0 #512
Conversation
Signed-off-by: codeflare-machine-account <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
thanks 💯
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@codeflare-machine-account: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
FTR - this is related to https://issues.redhat.com/browse/RHOAIENG-6338 (https://issues.redhat.com/browse/RHOAIENG-5085). |
BTW - each update like this also requires update in metadata for the affected image version of image streams that contain the codeflare-sdk installed. Right now its these lines:
I wonder whether it would make sense to make these changes part of the PRs like this already? |
ack, we would do the imagestream annotation update in a separate PR. |
@harshad16 in such case, please link it with this one issue https://issues.redhat.com/browse/RHOAIENG-6271 |
🚀 This is an automated Pull Request.
This PR updates the
Pipfile
to sync with latest Codeflare-SDK release.