-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop .z stream from Python version in JL main menu #49
Labels
Comments
The configuration had two goals:
- Remove the "(ipykernel)" mention that does not bring anything apart from
confusing people.
- Indicate the Python version, not for multiple kernels (you're right, it
won't happen much), but as a reminder of which image they launched. With
n-1 and n support, they may have in their RHODS environment 3.8 and 3.9
images, then 3.9 and 3.10...
Regarding the z version it's not really important, so it can be removed for
sure. It's a slight modification to make on the Dockerfile.
…On Mon., Mar. 6, 2023, 09:54 Luca Giorgi, ***@***.***> wrote:
After #25 <#25> , new
images display the full python version when launching into the JupyterLab
main menu.
For consistency with the Dashboard spawner page, I would suggest dropping
the .z stream from the version string.
@guimou <https://github.com/guimou> I understand you requested this to
enable users to deal with multiple kernel versions, do you think it would
be likely for users to use multiple kernel versions with the same minor but
different patch?
Perhaps it would be possible to only show the .z stream when two kernels
with the same minor versions are detected?
—
Reply to this email directly, view it on GitHub
<#49>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA6C4YUSFTVAF2LCGSR2GRDW2X3B7ANCNFSM6AAAAAAVRHJBCY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
3 tasks
harshad16
added
good first issue
Good for newcomers
kind/feature
New feature or request
labels
Jun 16, 2023
How to test code in local system:
|
3 tasks
PR Under review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After #25 , new images display the full python version when launching into the JupyterLab main menu.
For consistency with the Dashboard spawner page, I would suggest dropping the .z stream from the version string.
@guimou I understand you requested this to enable users to deal with multiple kernel versions, do you think it would be likely for users to use multiple kernel versions with the same minor but different patch?
Perhaps it would be possible to only show the .z stream when two kernels with the same minor versions are detected?
The text was updated successfully, but these errors were encountered: