Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop .z stream from Python version in JL main menu #49

Closed
lugi0 opened this issue Mar 6, 2023 · 3 comments · Fixed by #144
Closed

Drop .z stream from Python version in JL main menu #49

lugi0 opened this issue Mar 6, 2023 · 3 comments · Fixed by #144
Assignees
Labels
good first issue Good for newcomers kind/feature New feature or request

Comments

@lugi0
Copy link

lugi0 commented Mar 6, 2023

After #25 , new images display the full python version when launching into the JupyterLab main menu.
For consistency with the Dashboard spawner page, I would suggest dropping the .z stream from the version string.

@guimou I understand you requested this to enable users to deal with multiple kernel versions, do you think it would be likely for users to use multiple kernel versions with the same minor but different patch?

Perhaps it would be possible to only show the .z stream when two kernels with the same minor versions are detected?

@guimou
Copy link
Member

guimou commented Mar 6, 2023 via email

@harshad16
Copy link
Member

How to test code in local system:

  1. Make the changes in the notebook and build it with following code:
    podman build -t runtime . --build-arg BASE_IMAGE=[quay.io/opendatahub/workbench-images:jupyter-minimal-ubi9-python-3.9-2023a-20230605](http://quay.io/opendatahub/workbench-images:jupyter-minimal-ubi9-python-3.9-2023a-20230605)
  2. Run the code to test:
    podman run -p 8888:8888 localhost/runtime
  3. Make sure the python version z stream is not showing.

@harshad16 harshad16 moved this from 🔖Todo to 🏗 In Progress in ODH IDE Planning Jul 14, 2023
@harshad16
Copy link
Member

PR Under review
Moved this to next sprint 1.31.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers kind/feature New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants