Skip to content

Commit

Permalink
update contributing guide
Browse files Browse the repository at this point in the history
  • Loading branch information
jstourac committed Jul 10, 2024
1 parent 89a2bc2 commit bbbe4f3
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,3 +56,8 @@ Pull requests are the best way to propose changes to the notebooks repository:
### Testing your PR locally

- Test the changes locally, by manually running the `$make jupyter-${NOTEBOOK_NAME}-ubi8-python-3.8` from the terminal. This definitely helps in that initial phase.

### Review and Merge process

- Once the PR is submitted, you can either select particular reviewers or leave the bot to select reviewers automatically.
- To make PR merged, it has to get 2 `/lgtm` comments first from the repository [approvals/reviewers](/OWNERS). Then an `/approve` comment must be added by someone with approval rights. If the author of the PR has approval rights, it's preferred that he's the one who performs the merge action.

0 comments on commit bbbe4f3

Please sign in to comment.