Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick the etcd fix to the release branch #306

Conversation

mholder6
Copy link

@mholder6 mholder6 commented Oct 4, 2024

Motivation

Cherry-picked to fix as the previous resources in #303 was too low and caused modelmesh deployments to fail. -- this pr made limit and request values higher in the etcd container.

Modifications

Result

PR checklist

Checklist items below are applicable for development targeted to both fast and stable branches/tags

  • Unit tests pass locally
  • FVT tests pass locally
  • If the PR adds a new container image or updates the tag of an existing image (not build within cpaas), is the corresponding change made in live-builder and cpaas-midstream to add/update the image tag in the operator CSV? Link the PRs if applicable

Checklist items below are applicable for development targeted to both fast and stable branches/tags

  • Tested modelmesh serving deployment with odh-manifests and ran odh-manifests-e2e tests locally

@VedantMahabaleshwarkar
Copy link

pr is targeting the wrong branch

@mholder6 mholder6 changed the base branch from main to release-0.12.0-rc0 October 4, 2024 16:15
@mholder6
Copy link
Author

mholder6 commented Oct 4, 2024

Fixed target branch thanks @VedantMahabaleshwarkar

Copy link

@VedantMahabaleshwarkar VedantMahabaleshwarkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci openshift-ci bot added the approved label Oct 4, 2024
Copy link

openshift-ci bot commented Oct 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: israel-hdez, mholder6, VedantMahabaleshwarkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [VedantMahabaleshwarkar,israel-hdez]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@israel-hdez
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 1882912 into opendatahub-io:release-0.12.0-rc0 Oct 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants