Sync kserve/main (v0.11.1) to odh/main #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve#421) Set NAMESPACE_SCOPE environment to true or false in install script and test NAMESPACE_SCOPE environment variable in delete script to check whether ClusterServingRuntime should be deleted. Resolves kserve#420 --------- Signed-off-by: Rafael Vasquez <[email protected]>
- Increase the initial time to stabilize for predictor tests - Scale to zero before AllowAnyPVC tests --------- Signed-off-by: Christian Kadner <[email protected]>
Address deprecation warnings after updating to Go 1.19 (kserve#379) by updating deprecated code to use generic Set instead. Resolves kserve#386 --------- Signed-off-by: Rafael Vasquez <[email protected]>
Check for existence of "modelmesh-webhook-server-cert" certificate in serving namespace. Assume that cert-manager is used to generate certificates, if "modelmesh-webhook-server-cert" certificate exists. Conversely, if the Certificate is absent in the serving namespace, exclude cert-manager manifests from kustomization.yaml before undeploying ModelMesh Serving. Resolves kserve#399 --------- Signed-off-by: jooho <[email protected]>
Instead of comparing the version of the installed kustomize CLI, use the kustomize man pages to determine the supported format of the --load-restrictor parameter. Closes kserve#427 Signed-off-by: Jan Wytze Zuidema <[email protected]> Signed-off-by: Christian Kadner <[email protected]> Co-authored-by: Christian Kadner <[email protected]>
Stop goroutines when the label `modelmesh-enabled` is removed from a namespace or the namespace is deleted. If the request namespace does not exist, do not retry to get the information again. Closes kserve#385 --------- Signed-off-by: jooho <[email protected]>
Update FVT workflow definition to run on `workflow_dispatch` event Signed-off-by: Christian Kadner <[email protected]>
Add new approvers to OWNERS file following KServe community process. Closes kserve/community#6 /approved by @njhill --- Signed-off-by: Christian Kadner <[email protected]>
Add ClusterScope condition statement to list namespace that is only allowed for cluster-scope. Resolves kserve#433 --------- Signed-off-by: jooho <[email protected]>
Update KServe and CRDs in preparation for v0.11.1 release - Update go.mod dependencies - Update CRDs under config/crd/bases --------- Signed-off-by: Rafael Vasquez <[email protected]>
This reverts commit 1773d7d.
|
/retest |
|
/meow |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test all |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: heyselbi, VedantMahabaleshwarkar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Sync kserve/main to odh/main.
v0.11.1tag points to the latest commit in kserve/modelmesh-serving:main.Testing instructions
git clone [email protected]:opendatahub-io/modelmesh-serving.gitcd modelmesh-servingTAG=fast CONTROLLERNAMESPACE=opendatahub NAMESPACE=modelmesh-serving CUSTOM_IMG=modelmesh-controller=quay.io/opendatahub/modelmesh-controller:pr-229 make deploy-mm-for-odhCheck that the modelmesh controller deployment/pod has the correct image (shown in step 3). If not, patch it:
oc patch deployment modelmesh-controller -n opendatahub --type='json' -p='[{"op": "replace", "path": "/spec/template/spec/containers/0/image", "value": "quay.io/opendatahub/modelmesh-controller:pr-229"}]'Check that the manager container of modelmesh-controller and of odh-model-controller show no error.
TAG=fast CONTROLLERNAMESPACE=opendatahub NAMESPACE=modelmesh-serving FORCE=true make deploy-fvt-for-odhCheck that modelmesh-controller container, odh-model-controller container and runtime containers show no error.
Clean up:
C_MM_CTRL_KFCTL=true C_MM_TEST=true make cleanup-for-odhPR checklist
Checklist items below are applicable for development targeted to both fast and stable branches/tags
Checklist items below are applicable for development targeted to both fast and stable branches/tags