-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move model-mesh to opendatahub/manifests #221
move model-mesh to opendatahub/manifests #221
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VedantMahabaleshwarkar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Vedant Mahabaleshwarkar <[email protected]>
Signed-off-by: Vedant Mahabaleshwarkar <[email protected]>
Signed-off-by: Vedant Mahabaleshwarkar <[email protected]>
b472cb9
to
505c14f
Compare
Signed-off-by: Vedant Mahabaleshwarkar <[email protected]>
@VedantMahabaleshwarkar Rather them maintaining manifest in |
replaced by #237 |
Description
odh-manifests/model-mesh/odh-modelmesh-controller
and put them inopendatahub/manifests
along with nessary changes to work with the new directory structureTesting
The testing for this PR is to be done along with the testing for this and this PR since they target the same set of overall changes.
The ODH operator image has been built with the following changes :
quay.io/vedantm/odh-model-controller:remove-kserve-flag
which contains the changes for this PR.How Has This Been Tested?
ModelMesh testing
git clone [email protected]:VedantMahabaleshwarkar/opendatahub-operator.git
cd opendatahub-operator
manifests_transition_mlserving
make deploy -e IMG=quay.io/vedantm/opendatahub-operator:latest
opendatahub-operator-system
with the imagequay.io/vedantm/opendatahub-operator:latest
opendatahub
Kserve testing
git clone [email protected]:VedantMahabaleshwarkar/opendatahub-operator.git
cd opendatahub-operator
manifests_transition_mlserving
make deploy -e IMG=quay.io/vedantm/opendatahub-operator:latest
opendatahub-operator-system
with the imagequay.io/vedantm/opendatahub-operator:latest
opendatahub
Merge criteria: