Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a more meaningful templating name other than "foo" during parsing #114

Closed
zdtsw opened this issue Jun 19, 2023 · 3 comments · Fixed by kserve/modelmesh-serving#465
Closed

Use a more meaningful templating name other than "foo" during parsing #114

zdtsw opened this issue Jun 19, 2023 · 3 comments · Fixed by kserve/modelmesh-serving#465
Assignees
@israel-hdez

Comments

@zdtsw
Copy link
Member

zdtsw commented Jun 19, 2023

similar to issue opendatahub-io/data-science-pipelines-operator#16, here we name template as "foo" which should be improved to be something more meaningful when gets failure in the printout logs.
@heyselbi
Copy link

heyselbi commented Dec 5, 2023

@zdtsw could you provide more details, if this is still an issue?

@zdtsw
Copy link
Member Author

zdtsw commented Dec 6, 2023

line

modelmesh-serving/controllers/config/templating.go

Line 52 in a14b7c8

t, err := template.New("foo").Parse(string(b))

i would not say it is a bug but a low priority good to have issue, just rename it for better logging

@israel-hdez israel-hdez mentioned this issue Dec 20, 2023
Merged
@israel-hdez israel-hdez self-assigned this Dec 20, 2023
rafvasq pushed a commit to kserve/modelmesh-serving that referenced this issue Jan 18, 2024
@israel-hdez
fix: Replace "foo" string with a less generic one (#465)
a2ce947 
If template parsing fails, the "foo" string would appear in pod logs.
This should be very hard to happen, since the template is built-in.
Changing, simply, to have more meaningful logs.

Fixes opendatahub-io#114

Signed-off-by: Edgar Hernández <[email protected]>
@israel-hdez
Copy link

Fixed.

@github-project-automation github-project-automation bot moved this from New/Backlog to Done in ODH Model Serving Planning Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@israel-hdez israel-hdez

Labels
None yet
Projects
Internal tracking
Status: Done
ODH Feature Tracking
Status: No status
ODH Model Serving Planning
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace "foo" string with a less generic one israel-hdez/modelmesh-serving
3 participants
@zdtsw @israel-hdez @heyselbi