Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extra logger to track modelmesh #64

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add extra logger to track modelmesh #64

wants to merge 2 commits into from

Conversation

vaibhavjainwiz
Copy link
Member

Motivation

Modifications

Result

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 6, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaibhavjainwiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 6, 2024
MohammadiIram pushed a commit to rhoai-rhtap/modelmesh-runtime-adapter that referenced this pull request Aug 8, 2024
@spolti
chore: Upgrade Golang version from 1.17 to 1.19 (opendatahub-io#68)
0ba2f47 
- Remove the linters for "deadcode", "structcheck", "varcheck"
- Use "os" packages instead of deprecated "io/ioutil" (SA1019)
- Capture pre-commit output in a local log file

Fixes opendatahub-io#64

---------

Signed-off-by: Spolti <[email protected]>
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@spolti
Copy link
Member

spolti commented Oct 1, 2024

@vaibhavjainwiz hi, do you mind rebasing your Pull Request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved do-not-merge/work-in-progress needs-rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vaibhavjainwiz @openshift-merge-robot @spolti @rpancham